-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance problems on Windows 10's Windows Subsystem for Linux #63
Comments
Performance could use some work on my macbook too. I profiled it using the instructions at https://stackoverflow.com/questions/5014823/how-to-profile-a-bash-shell-script-slow-startup by dropping the first part at the top of Line 392 in 82d693a
Then |
Same problem here with WSL (same version as @ethanherbertson), to the point I have to consider other solutions (as much as I love smartcd's feature set). I've noticed that ondir does not exhibit this issue (no delay when switching with the non builtin cd). Since ondir is implemented in C, this could indeed point to bash running on WSL being inefficient. |
Update: With the October 2018 Windows build, and with Ubuntu 18 LTS, this issue seems to be much less serious. Changing directories with smartcd installed now seems to take between half a second and a second. |
I've been trying to find some time to rework some of the internals to use less expensive operations which may further reduce the impact of this. Thanks for your patience on this |
Sorry to pollute this thread with my question, but @ethanherbertson can you please tell me if switching your Windows build from the old to the new one (version 1809?) preserved your whole WSL setup? I would be interested to give it a try if it's harmless. Thanks. |
It did. I didn't test the Ubuntu 16 install much before upgrading it
(in-place) to 18, though.
…On Tue, Mar 19, 2019, 6:27 PM mortelle1806 ***@***.***> wrote:
*Update:* With the October 2018 Windows build, and with Ubuntu 18 LTS,
this issue seems to be much less serious. Changing directories with smartcd
installed now seems to take between half a second and a second.
Sorry to pollute this thread with my question, but @ethanherbertson
<https://github.com/ethanherbertson> can you please tell me if switching
your Windows build from the old to the new one (version 1809?) preserved
your whole WSL setup? I would be interested to give it a try if it's
harmless. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGGKTESoW4gtK-pnrend_fsR04o0vXKJks5vYXJngaJpZM4VJiHL>
.
|
I suspect this is not something that can feasibly be fixed, however I figured I'd better report it anyway.
After installing smartcd in my Windows Subsystem for Linux (the Ubuntu 16.04 LTS flavor), changing directories—even ones without "enter" scripts—began taking multiple seconds to complete. Before installing smartcd, and after uninstalling smartcd, changing directories takes somewhere between a tenth of a second and half a second.
I believe it is a known shortcoming with WSL that filesystem actions can take significantly longer than what you'd expect, if for no other reason than NTFS is frequently not optimized for the same kinds of activities that Linux filesystems are. However, I suspect in this case the problem is more due to inefficiencies in WSL's bash—possibly in the implementation of functions?—than any filesystem/hardware shenanigans.
For now I've uninstalled the tool rather than look into it further. If you want me to help debug I'm willing, but if you're inclined to "will not fix" this I'd understand that as well.
The text was updated successfully, but these errors were encountered: