Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch in reference data and scanned data #2

Open
zelima opened this issue Mar 15, 2017 · 1 comment
Open

Mismatch in reference data and scanned data #2

zelima opened this issue Mar 15, 2017 · 1 comment
Assignees
Milestone

Comments

@zelima
Copy link
Contributor

zelima commented Mar 15, 2017

Discovered that the country ID of ASN 204136 from scanned data is AQ (Antarctica), But in our reference data from https://stat.ripe.net it is asigned to AT (Austria)

Eg:
Result from scanned data https://cybergreen-staging.herokuapp.com/api/v1/count?asn=204136

{
"total": 27,
"results": [
   {
     "country": "AQ",
      "risk": 1,
      "asn": 204136,
      "date": "2016-12-25",
      "count": 2,
      "count_amplified": 82
    }
  ]
}

Result from the reference data https://cybergreen-staging.herokuapp.com/api/v1/asn?asn=204136

{
"total_pages": 1,
"results": [
    {
      "country": "AT",
      "number": 204136,
      "title": "FUSLVZ-LTD-AS"
    }
  ]
}

This causes unexpected behaviors on AS performance page and leads to AS title = Unknown as it is searching Title for AS in given country (but can not find)

@zelima zelima added this to the Backlog milestone Mar 15, 2017
@aaronkaplan
Copy link

Yes, good catch. The assignements of IP 2 country and ASN to country don't always match.
Thats just how it is.
It would be good if the UI then can simply return an error message and/or no data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants