Skip to content

Commit 39dc75a

Browse files
authoredNov 14, 2019
fix: stringify coverage object to improve performance (#98)
1 parent dd33776 commit 39dc75a

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed
 

‎support.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ if (Cypress.env('coverage') === false) {
2323
const applicationSourceCoverage = win.__coverage__
2424

2525
if (applicationSourceCoverage) {
26-
cy.task('combineCoverage', applicationSourceCoverage)
26+
cy.task('combineCoverage', JSON.stringify(applicationSourceCoverage))
2727
}
2828
})
2929
})
@@ -54,7 +54,7 @@ if (Cypress.env('coverage') === false) {
5454
// original failed request
5555
return
5656
}
57-
cy.task('combineCoverage', coverage)
57+
cy.task('combineCoverage', JSON.stringify(coverage))
5858
})
5959
}
6060

@@ -75,7 +75,7 @@ if (Cypress.env('coverage') === false) {
7575
(fileCoverage, filename) =>
7676
filename.startsWith(specFolder) || filename.startsWith(supportFolder)
7777
)
78-
cy.task('combineCoverage', coverage)
78+
cy.task('combineCoverage', JSON.stringify(coverage))
7979
}
8080

8181
// when all tests finish, lets generate the coverage report

‎task.js

+7-1
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,14 @@ module.exports = {
6161
/**
6262
* Combines coverage information from single test
6363
* with previously collected coverage.
64+
*
65+
* @param {string} sentCoverage Stringified coverage object sent by the test runner
66+
* @returns {null} Nothing is returned from this task
6467
*/
65-
combineCoverage(coverage) {
68+
combineCoverage(sentCoverage) {
69+
const coverage = JSON.parse(sentCoverage)
70+
debug('parsed sent coverage')
71+
6672
fixSourcePathes(coverage)
6773
const previous = existsSync(nycFilename)
6874
? JSON.parse(readFileSync(nycFilename))

0 commit comments

Comments
 (0)
Please sign in to comment.