chore: purge binary manifest file (#32363)

Author: mschile

guides/release-process.md

@@ -37,7 +37,7 @@ The `@cypress/`-namespaced NPM packages that live inside the [`/npm`](../npm) di
     GITHUB_PRIVATE_KEY=
     ```
 
-  - For purging the Cloudflare cache (needed for the `prepare-release-artifacts` script in step 6), you'll need `CF_ZONEID` and `CF_TOKEN` set. These can be found in 1Password.
+  - For purging the Cloudflare cache (needed for the `prepare-release-artifacts` script in step 6 and `binary-release` in step 14), you'll need `CF_ZONEID` and `CF_TOKEN` set. These can be found in 1Password.
       ```text
       CF_ZONEID="..."
       CF_TOKEN="..."

scripts/binary/index.js

@@ -135,6 +135,9 @@ const deploy = {
         fail('Release Failed')
         throw err
       })
+      .then(() => {
+        return this.checkManifest({ version })
+      })
       .then(() => {
         return this.checkDownloads({ version })
       })
@@ -144,6 +147,33 @@ const deploy = {
     .then(release)
   },
 
+  checkManifest ({ version }) {
+    const checkManifest = () => {
+      const url = `https://download.cypress.io/desktop.json`
+
+      process.stdout.write(`Checking for ${chalk.yellow(version)} in the manifest at ${chalk.cyan(url)} ... `)
+
+      return rp.get(url)
+      .then((res) => {
+        const manifest = JSON.parse(res)
+
+        return manifest
+      })
+    }
+
+    return checkManifest().then((manifest) => {
+      const versionMatches = manifest.version === version
+
+      process.stdout.write(`${versionMatches ? '✅' : '❌'}\n`)
+
+      if (!versionMatches) {
+        console.log(chalk.red(`\nFound ${manifest.version} in the manifest, but ${version} was requested.`))
+
+        process.exit(1)
+      }
+    })
+  },
+
   checkDownloads ({ version }) {
     const systems = [
       { platform: 'linux', arch: 'x64' },

scripts/binary/upload.js

@@ -131,6 +131,9 @@ module.exports = {
         return fs.removeAsync(manifest)
       })
     })
+    .then(() => {
+      return uploadUtils.purgeDesktopManifest()
+    })
   },
 
   toS3 ({ file, uploadPath }) {

scripts/binary/util/upload.js

@@ -84,6 +84,12 @@ const getDesktopUrl = function (version, osName, zipName) {
   return [url, 'desktop', version, osName, zipName].join('/')
 }
 
+const purgeDesktopManifest = function () {
+  const url = getUploadUrl()
+
+  return purgeCloudflareCache([url, 'desktop', 'manifest.json'].join('/'))
+}
+
 // purges desktop application url from Cloudflare cache
 const purgeDesktopAppFromCache = function ({ version, platformArch, zipName }) {
   la(check.unemptyString(version), 'missing desktop version', version)
@@ -162,6 +168,7 @@ module.exports = {
   getPublisher,
   purgeDesktopAppFromCache,
   purgeDesktopAppAllPlatforms,
+  purgeDesktopManifest,
   getUploadNameByOsAndArch,
   validPlatformArchs,
   getValidPlatformArchs,