chore: fix local login flow where detecting machine ID is having ts-node interopt issues when loading the machine-id library (#32727)

Author: AtofStryker

packages/server/lib/cloud/api/index.ts

@@ -8,7 +8,7 @@ import * as RequestErrors from '@cypress/request-promise/errors'
 
 import pkg from '@packages/root'
 
-import * as machineId from '../machine_id'
+import { machineId } from '../machine_id'
 import * as errors from '../../errors'
 
 import Bluebird from 'bluebird'
@@ -607,7 +607,7 @@ export default {
   postLogout (authToken) {
     return Bluebird.join(
       this.getAuthUrls(),
-      machineId.machineId(),
+      machineId(),
       (urls, machineId) => {
         return rp.post({
           url: urls.dashboardLogoutUrl,

packages/server/lib/cloud/machine_id.ts

@@ -1,8 +1,11 @@
-import nmi from 'node-machine-id'
+import { machineId as nodeMachineId } from 'node-machine-id'
 
-export function machineId () {
-  return nmi.machineId()
-  .catch(() => {
+export async function machineId () {
+  try {
+    const machineId = await nodeMachineId()
+
+    return machineId
+  } catch (error) {
     return null
-  })
+  }
 }