Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More examples #133

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

More examples #133

wants to merge 8 commits into from

Conversation

rbaheti
Copy link
Contributor

@rbaheti rbaheti commented May 21, 2019

Description

closes#133

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have documented all new methods.
  • I have written tests for all new methods/functionality.
  • I have written examples for all new methods/functionality.

Checklist of new examples

  • Scatter Plot grouping
  • Line Plot Grouping
  • Hiding Tooltip
  • Change Box and Whisker mode

@@ -0,0 +1,41 @@
# Using a Different Box and Whisker Mode

Mode in a Box and Whisker plot changes the extent of the whiskers. The [BoxWhisker](http://d3plus.org/docs/#BoxWhisker) mode defaults to being `tukey`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make into one paragraph:

The "mode" of a Box and Whisker plot changes the placement of the extent of the whiskers. The [`BoxWhisker`](http://d3plus.org/docs/#BoxWhisker) class defaults to using the "[tukey](https://en.wikipedia.org/wiki/Box_plot#Variations)" method, but this can be changed by setting the `whiskerMode` property of the [`Box`](http://d3plus.org/docs/#Box) shape class using [shapeConfig](http://d3plus.org/docs/#Viz.shapeConfig). Accepted values are `"tukey"`, `"extent"`, or an Array of 2 numbers used as the bottom and top percentile.

Also, double check me on that description of using 2 numbers 👆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description is correct, but passing array of numbers is breaking the code. Will try to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants