Any hope for php 8?

[cptX]

Is there any hope/plan for supporting php 8.*?

[mazzarito]

I have it running on 8 I'll see if i can put a patch together. Much less work than the PHP 7 conversion was.

[cptX]

I'm using Pressflow and I'm stack some versions behind. I now checked the changelog and it seems that the initial attempt for php 8 has began. That's good news!

[dranii]

Hello @mazzarito is it possible to make a zip of the version running in php 8 available for testing? It will be great help not just to me or hundreds but thousand of users. Many thanks.

[dranii]

@cptX if possible can you kindly share the link of Pressflow/drupal that seems to work or may work with php8? Best regards.

[cptX]

@dranii I'm running it on php 7.4. Never tested it with php 8 although my server now is php 8 and I don't want to have dual versions of php running.
I tried to check the code with phan but I got 100.000 lines of errors so it's impossible to detect any php 8 incompatibilities with this tool. If anybode knows how to suppress messages like Undeclared functions, methods, etc... let me know, please!

[dranii]

@cptX 2 separate instances of Drupal 6x can run from two separate "folders" mydomain/abc/drupal6x and mydomain/xyz/drupal6x - now by "defining" via htaccess we can run one in php7x and another in php8x, as you know well. I am not sure which version of php8 we should first try with a minimum of modules. I was looking at this page - please have a look too if it can give a pointer or any help - https://programmingflow.com/2021/09/19/upgrading-old-drupal-6.html https://docs.lando.dev/drupal/
Thanks and regards.

[cptX]

@dranii my server is ubuntu 22.04 and the long term stable version of php is 8.1.x
I suggest to focus compatibility with this version.

[dranii]

@cptX That sounds good. I think I will be able to test with php 8.1x also. However I am not sure what should be a good starting point. I hope someone comes forward with a reasonable starting point. Thanks.

[neilt1700]

I have it running on 8 I'll see if i can put a patch together. Much less work than the PHP 7 conversion was.

Drupal 6 core seems to be running fine on my site without needing to change anything. However some contributed modules caused fatal errors. These were:

• Using curly brackets for array elements (removed in PHP 8)
• Passing a variable of the wrong type to internal functions - which used to assume a reasonable value, but now throws an exception

I will need to do more testing (with my 70+ contrib modules) before putting into production

[dranii]

@neilt1700 Thanks a lot. Basically we are getting error messages only with d6lts and php8.
It may be that some additional extensions for php 8 or some settings to be adjusted ?? If possible, can the php info file and what hosting you are using for d6lts+php8x be shared here? What changes need to be done for Views and CCK ?

[neilt1700]

@dranii for CCK here on d6lts, I don't know - perhaps nothing? I am using CCK 6.x-3.0-alpha4 as this has a multi-group feature that never made it beyond alpha. I needed to do this fix (note it's already been fixed in the CCK repo here):

diff --git a/httpdocs/sites/all/modules/contrib/cck/content.module b/httpdocs/sites/all/modules/contrib/cck/content.module
index b682d48..8d3f801 100644
--- a/httpdocs/sites/all/modules/contrib/cck/content.module
+++ b/httpdocs/sites/all/modules/contrib/cck/content.module
@@ -1227,7 +1227,7 @@ function content_write_record($table, &$object, $update = array()) {
     }

     // Build arrays for the fields, placeholders, and values in our query.
-    if (isset($object->$field) || array_key_exists($field, $object)) {
+    if (isset($object->$field) || (is_array($object) && array_key_exists($field, $object))) {
       $fields[] = $field;
       if (isset($object->$field)) {
         $placeholders[] = db_type_placeholder($info['type']);

The one fix I've needed to do for views had already been done here - see: d6lts/views@e2f15e5 (So note to self - make sure I have indeed got the latest d6lts modules!)

[neilt1700]

Other modules that I use that needed fixing:

• Better Formats (usage of curly braces for array elements) - not a d6lts repo
• Faceted Search (usage of curly braces for array elements) - that is a d6lts repository - but hadn't been fixed
• Image API (usage of curly braces for array elements) - is a d6lts repo - and fix had already been made

[neilt1700]

I have updated D6 core to make it function with PHP 8.1 (as on further checking there was a small amount of code in core which were causing fatal errors in PHP 8). I have made a pull request to bring the changes over to here: #78. You can get the code from here to try it out.

I've updated a number of other modules which I will submit shortly:

• better_formats
• faceted_search
• imageapi
• linkchecker
• multistep
• nodeformsettings
• revision_moderation
• rules
• simplenews
• smtp
• taxonomy_super_select
• user_delete
• uuid
• view_revisions_by_content_type
• views
• views_bulk_operations

[cptX]

Great job, thanks for your effort!

What tool are you using to detect the incompatibilities in the code?

[amorsent]

FYI I have several open PHP 8 pull requests for contrib modules:

d6lts/elysia_cron#3
d6lts/features#2
d6lts/ubercart#6
d6lts/ubercart#7
d6lts/filefield#1
d6lts/filefield_paths#1
d6lts/filefield_paths#2
d6lts/ctools#4
d6lts/views_bulk_operations#2
d6lts/emfield#1

I have other changes for some contrib modules not listed on D6LTS.
Does anyone know if there is a process for including additional contrib modules here?