Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SigV4-S3 Support #5

Open
ghost opened this issue Jun 10, 2022 · 5 comments
Open

SigV4-S3 Support #5

ghost opened this issue Jun 10, 2022 · 5 comments
Assignees

Comments

@ghost
Copy link

ghost commented Jun 10, 2022

Hello, I don't know why but https does not seem to work. The request headers seem to be the same so I am not sure what is stopping it from working. The signatures do not match. Do you have any idea? Thank you.

@ghost
Copy link
Author

ghost commented Jun 10, 2022

Found the problem, in canonical request it was trying to compute body_digest where it should only have stated "UNSIGNED-PAYLOAD" in order to match what the client was sending (last line of canonical request).

@dacut
Copy link
Owner

dacut commented Jun 10, 2022 via email

@dacut dacut self-assigned this Jun 10, 2022
@dacut dacut changed the title HTTPS Support SigV4-S3 Support Jun 10, 2022
@ghost
Copy link
Author

ghost commented Jun 10, 2022

@dacut Thank you, that makes sense. Switching to awssig.AWSSigV4S3Verifier from awssig.AWSSigV4Verifier works without errors somehow but I just noticed that it lacks the functionality that collects and computes everything. It's a personal project that I started recently, nothing serious yet.

@dacut
Copy link
Owner

dacut commented Jun 10, 2022

Ah, maybe I had gotten further along that I had remembered. Yes, this is also a personal project that I haven't touched in awhile, so I can't remember exactly where I was with the S3 version.

@ghost
Copy link
Author

ghost commented Jun 10, 2022

@dacut It seems that you have implemented AWSSigV4S3Verifier to a working degree at least, it inherits from AWSSigV4Verifier the rest of the stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant