Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define base and target folders paths #104

Open
jchanam opened this issue Jan 24, 2025 · 2 comments
Open

Allow to define base and target folders paths #104

jchanam opened this issue Jan 24, 2025 · 2 comments
Labels
feature-request Feature Request

Comments

@jchanam
Copy link

jchanam commented Jan 24, 2025

Right now, when the base and the target are created, the folder path is hardcoded. This is also a relative path to the working directory.

pub fn folder_name(&self) -> &str {
match self.branch_type {
BranchType::Base => "base-branch",
BranchType::Target => "target-branch",
}
}
}

I'd suggest to have an environment variable / flag to allow these paths to be overwritten, so we can run the app from any working directory.

@dag-andersen
Copy link
Owner

Hi @jchanam,
Thank you for your interest in the project!
Am I correct in assuming that this feature would be most useful when running the binary directly (and not in Docker)?

@dag-andersen dag-andersen added good first issue Good for newcomers feature-request Feature Request and removed good first issue Good for newcomers labels Jan 26, 2025
@jchanam
Copy link
Author

jchanam commented Jan 27, 2025

I think it'd be useful in both cases. Being able to configure via flag/env where the app will read/write files adds flexibility for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Feature Request
Projects
None yet
Development

No branches or pull requests

2 participants