fix(profile): invalidate profile cache when experience is saved/deleted #5428
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When saving or deleting work experience in settings, the profile page cache was not invalidated, causing stale data to be displayed when navigating back to the user profile. Added invalidation of the profile experiences query key alongside the existing settings query key invalidation in both useUserExperienceForm and useRemoveExperience hooks. Co-Authored-By: Claude Opus 4.5 <[email protected]>
idoshamun
requested review from
AmarTrebinjac,
capJavert,
omBratteng and
rebelchris
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
idoshamun
deleted the
eng-84-work-experience-not-invalidated-when-returning-to-profile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The issue occurred because the settings page and profile page use different query keys for experiences. When saving/deleting in settings, only the settings query key was invalidated, but the profile page was still using its cached (now stale) data.
Test plan
Closes ENG-84
Created by Huginn 🐦⬛
Preview domain
https://eng-84-work-experience-not-inval.preview.app.daily.dev