Skip to content

Conversation

@egli
Copy link
Member

@egli egli commented Sep 28, 2022

With this change all versions above Java 1.5 (including Java 11) should be valid run times.

@bertfrees
Copy link
Member

@egli Have you also checked that it actually works with Java 11?

@egli
Copy link
Member Author

egli commented Oct 6, 2022

Hi @bertfrees I tested via shell, i.e. bash:

$ java -version
openjdk version "1.8.0_342"
OpenJDK Runtime Environment (build 1.8.0_342-8u342-b07-0ubuntu1~22.04-b07)
OpenJDK 64-Bit Server VM (build 25.342-b07, mixed mode)
$ java -version 2>&1 | head -1 | cut -d'"' -f2 | sed '/^1\./s///' | cut -d'.' -f1
8
$ java -version
openjdk version "11.0.16" 2022-07-19
OpenJDK Runtime Environment (build 11.0.16+8-post-Ubuntu-0ubuntu122.04)
OpenJDK 64-Bit Server VM (build 11.0.16+8-post-Ubuntu-0ubuntu122.04, mixed mode, sharing)
$ java -version 2>&1 | head -1 | cut -d'"' -f2 | sed '/^1\./s///' | cut -d'.' -f1
11

And yes, I also built a version of the pipeline1 (using Java8) and ran it under Java11 (with the patched launcher script). I then tested the ConfigurableValidator script with daisy202 and with DTBook and also the DTBAudioEncoder. They both worked.

@bertfrees
Copy link
Member

Ok, so I guess some things will work, but other things will not. It would be nice to have a warning.

@NPavie Is your patch that updates Pipeline 1 to Java 8 in a state in which a PR can be made from it? Do you think that after applying it a warning is still required?

@NPavie
Copy link
Contributor

NPavie commented Oct 7, 2022

@bertfrees i'll have to check again, i have not touch the pipeline 1 build in a while.
I'll see if i can validate the code for a PR today, so that we should be able to merge both.

@bertfrees
Copy link
Member

See #5

@egli
Copy link
Member Author

egli commented Oct 7, 2025

Replaced by #12

@egli egli closed this Oct 7, 2025
@egli egli deleted the start-script-java-11 branch October 7, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants