-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added background image input to visualize.pseudocolor #1680
base: main
Are you sure you want to change the base?
Conversation
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
Haha, ok, DeepSource is a little picky about the white space in the docstring. I'll fix that. I also forgot to add this to the documentation |
@HaleySchuhl I'm missing an example image for the documentation. I already prepared everything in the md file, but I could not find the original image that was used for the I'm calling "img/documentation_images/pseudocolor/pseudo_on_rgb_image.jpg" as image, but this image does not exist yet. |
edited: We also discussed this morning that adding a new parameter |
This absolutely makes sense! |
@HaleySchuhl The whole magic of this part needs to be replaced, because Is this fine with you? # Set the background color or type
bkgd = {
"BLACK": {
"image": np.zeros(np.shape(gray_img1), dtype=np.uint8),
"cmap": "gray"
},
"WHITE": {
"image": np.zeros(np.shape(gray_img1), dtype=np.uint8) + 255,
"cmap": "gray_r"
},
"IMAGE": {
"image": bg_image1 if bg_image1 is not None else gray_img1,
"cmap": None if bg_image1 is not None else "gray"
}
}
bkg_img = bkgd[background.upper()]["image"]
bkg_cmap = bkgd[background.upper()]["cmap"] |
Hey @HaleySchuhl Just one thing: |
Describe your changes
Added an option/input for a RGB image that will be uses as a background in
plantcv.visualize.pseudocolor()
Type of update
Is this a:
Associated issues
Closes #1650
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md