Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metadata to _package_index in spectral_index.py #1673

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HaleySchuhl
Copy link
Contributor

Describe your changes
add metadata attribute (a relatively new attribute for Spectral_data class instances. This change is inside _package_index in spectral_index.py

Type of update
Is this a:

  • Bug fix
  • feature enhancement

Associated issues

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added bugfix Bug fixes ready to review update Updates an existing feature/method labels Feb 14, 2025
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.7 milestone Feb 14, 2025
@HaleySchuhl HaleySchuhl self-assigned this Feb 14, 2025
Copy link

deepsource-io bot commented Feb 14, 2025

Here's the code health analysis summary for commits e160b2a..cf74a14. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

replace with updated Spectral_data so that it includes metadata attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes ready to review update Updates an existing feature/method
Projects
Status: Pull Requests
Development

Successfully merging this pull request may close these issues.

metadata attribute is missing in calculated spectral indices
1 participant