Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian lintian warnings #2831

Closed
dankamongmen opened this issue Jan 9, 2025 · 8 comments
Closed

debian lintian warnings #2831

dankamongmen opened this issue Jan 9, 2025 · 8 comments
Assignees
Labels
bug Something isn't working packaging schlepping up distro packages
Milestone

Comments

@dankamongmen
Copy link
Owner

saw this when uploading 3.0.12 (https://salsa.debian.org/debian/notcurses/-/jobs/6867258):

25 Lintian v2.121.1
26 $ if lintian --fail-on error --allow-root > /dev/null ; then
38 $ lintian --suppress-tags "${SALSA_CI_LINTIAN_SUPPRESS_TAGS}" --display-info --pedantic ${SALSA_CI_LINTIAN_FAIL_ARG} --allow-root ${SALSA_CI_LINTIAN_SHOW_OVERRIDES_ARG} ${SALSA_CI_LINTIAN_ARGS} ${WORKING_DIR}/*.changes | tee lintian.output || ECODE=$?
39 W: notcurses source: debian-watch-could-verify-download debian/upstream/signing-key.asc [debian/watch]
40 I: notcurses source: dot-before-repack-count 3.0.11+dfsg.1-3+salsaci+20250105+366
41 I: notcurses-bin: hardening-no-fortify-functions [usr/bin/nctetris]
42 I: python3-notcurses: hardening-no-fortify-functions [usr/lib/python3/dist-packages/_notcurses.abi3.so]
43 I: libnotcurses++3: no-symbols-control-file usr/lib/x86_64-linux-gnu/libnotcurses++.so.3.0.11
44 I: notcurses-bin: spelling-error-in-binary leat least [usr/bin/notcurses-demo]
45 I: libnotcurses-core-dev: unused-override groff-message  [usr/share/lintian/overrides/libnotcurses-core-dev:2]
46 I: notcurses-bin: unused-override groff-message  [usr/share/lintian/overrides/notcurses-bin:2]
47 I: python3-notcurses: unused-override groff-message  [usr/share/lintian/overrides/python3-notcurses:2]
48 I: notcurses source: uses-deprecated-python-stdlib distutils (deprecated in Python 3.10, removed in Python 3.12) [cffi/setup.py:4]
49 N: 0 hints overridden; 3 unused overrides

that distutils message is upsetting. how i loathe python, always and forever.

@dankamongmen dankamongmen added the bug Something isn't working label Jan 9, 2025
@dankamongmen dankamongmen self-assigned this Jan 9, 2025
@dankamongmen dankamongmen added the packaging schlepping up distro packages label Jan 9, 2025
@dankamongmen dankamongmen added this to the 3.1.0 milestone Jan 9, 2025
@dankamongmen
Copy link
Owner Author

i pulled the groff-message entries from override files, allowing me to completely kill two of the three override specs, huzzah!

@dankamongmen
Copy link
Owner Author

ok #2832 deals with the python crappage

@dankamongmen
Copy link
Owner Author

https://lintian.debian.org/tags/dot-before-repack-count.html explains dot-before-repack-count. apparently we ought be using +dfsgN, not +dfsg.N. we can't change it right now, though, because that'll break sorting. we need to remember to do this when we next release. maybe i'll do that very soon, especially if we make other headway on this bug.

@dankamongmen
Copy link
Owner Author

https://lintian.debian.org/tags/hardening-no-fortify-functions.html explains hardening-no-fortify-functions. i think we just need to import CPPFLAGS in override_dh_auto_build over in our debian packaging.

@dankamongmen
Copy link
Owner Author

we're down to:

Lintian v2.121.1
26 $ if lintian --fail-on error --allow-root > /dev/null ; then
38 $ lintian --suppress-tags "${SALSA_CI_LINTIAN_SUPPRESS_TAGS}" --display-info --pedantic ${SALSA_CI_LINTIAN_FAIL_ARG} --allow-root ${SALSA_CI_LINTIAN_SHOW_OVERRIDES_ARG} ${SALSA_CI_LINTIAN_ARGS} ${WORKING_DIR}/*.changes | tee lintian.output || ECODE=$?
39 I: notcurses source: anticipated-repack-count 3.0.12+dfsg1-1+salsaci+20250110+377
40 I: notcurses-bin: hardening-no-fortify-functions [usr/bin/nctetris]
41 I: python3-notcurses: hardening-no-fortify-functions [usr/lib/python3/dist-packages/_notcurses.abi3.so]
42 I: libnotcurses++3: no-symbols-control-file usr/lib/x86_64-linux-gnu/libnotcurses++.so.3.0.12
43 I: notcurses-bin: spelling-error-in-binary leat least [usr/bin/notcurses-demo]
44 I: notcurses source: uses-deprecated-python-stdlib distutils (deprecated in Python 3.10, removed in Python 3.12) [cffi/setup.py:4]
45 $ if echo "${SALSA_CI_LINTIAN_FAIL_WARNING}" | grep -qE '^(1|yes|true)$'; then

@dankamongmen
Copy link
Owner Author

@dankamongmen
Copy link
Owner Author

anticipated-repack-count ought go away now that we've gone to dfsg rather than dfsg1. yep, it's gone:

$ lintian --suppress-tags "${SALSA_CI_LINTIAN_SUPPRESS_TAGS}" --display-info --pedantic ${SALSA_CI_LINTIAN_FAIL_ARG} --allow-root ${SALSA_CI_LINTIAN_SHOW_OVERRIDES_ARG} ${SALSA_CI_LINTIAN_ARGS} ${WORKING_DIR}/*.changes | tee lintian.output || ECODE=$?
I: notcurses-bin: hardening-no-fortify-functions [usr/bin/nctetris]
I: python3-notcurses: hardening-no-fortify-functions [usr/lib/python3/dist-packages/_notcurses.abi3.so]
I: libnotcurses++3: no-symbols-control-file usr/lib/x86_64-linux-gnu/libnotcurses++.so.3.0.12
I: notcurses-bin: spelling-error-in-binary leat least [usr/bin/notcurses-demo]
I: notcurses source: uses-deprecated-python-stdlib distutils (deprecated in Python 3.10, removed in Python 3.12) [cffi/setup.py:4]
$ if echo "${SALSA_CI_LINTIAN_FAIL_WARNING}" | grep -qE '^(1|yes|true)$'; then

from https://salsa.debian.org/debian/notcurses/-/jobs/6894623

@dankamongmen
Copy link
Owner Author

alright, uploading 3.0.12+dfsg-1 to unstable.

whenever we cut the next release, uses-deprecated-python-stdlib will go away. i'm not too worried about the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working packaging schlepping up distro packages
Projects
None yet
Development

No branches or pull requests

1 participant