Building with CMake 3.16.3 fails due to invalid C_STANDARD value 17

[Joeyrp]

In CMakeLists.txt cmake_minimum_required is currently set to 3.14.0 and (on line 69) C_STANDARD is set to 17. But it appears that setting C_STANDARD to 17 is not supported in CMake until version 3.21 (see here: https://cmake.org/cmake/help/v3.21/prop_tgt/C_STANDARD.html).

The CONTRIBUTING.md mentions that notcurses is targeting c11 though so I'm not sure if you want to adjust the minimum CMake version required or change the C_STANDARD value. I was able to build successfully after changing C_STANDARD to 11.

Environment Info [not sure much of this is relevant but just in case]:

• LANG: C.UTF-8
  LC_CTYPE:
  TERM: xterm-256color
• notcurses version: 3.0.13 (from the CMakeLists.txt file). I'm trying to build the current master branch which is on this commit: 333455e
• fish 3.7.1 and bash 5.0.17
• Building on Ubuntu 20.04 in WSL 2
• CMake version 3.16.3
• gcc version 9.4.0

[dankamongmen]

thanks much for the heads up! i think depping on 3.21 is reasonable, unless anyone feels otherwise. let me update the docs and cmake stuff.

[dankamongmen]

that ought get it. hack on!