Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Apple Auth. #3438

Closed
1 task done
melodyxpot opened this issue Jul 23, 2024 · 5 comments · Fixed by #5473
Closed
1 task done

Enhancement: Apple Auth. #3438

melodyxpot opened this issue Jul 23, 2024 · 5 comments · Fixed by #5473
Assignees
Labels
✨ enhancement New feature or request

Comments

@melodyxpot
Copy link

What features would you like to see added?

I want to add apple login feature for auth.

More details

I think we can simple add apple auth package the current frontend and backend.

Which components are impacted by your request?

Plugins

Pictures

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@melodyxpot melodyxpot added the ✨ enhancement New feature or request label Jul 23, 2024
@berry-13
Copy link
Collaborator

https://discord.com/channels/1086345563026489514/1122124496749477958/1122618318889685083

If you provide me the keys, I can implement the auth but I won't pay for Apple Developer

@berry-13 berry-13 self-assigned this Jul 29, 2024
@melodyxpot
Copy link
Author

I will send the keys via discord

@robsoncombr
Copy link

robsoncombr commented Dec 24, 2024

Hey there, did this happen? I'm interested.
I think I can contribute to this implementation.
Please, let me know if there is there is some stuck code or anything.
Thank you!

@danny-avila
Copy link
Owner

@robsoncombr this is not implemented. PRs welcome

rubentalstra added a commit to rubentalstra/LibreChat that referenced this issue Jan 26, 2025
Closes: danny-avila#3438

TODO:
- write config Doc
@rubentalstra rubentalstra mentioned this issue Jan 26, 2025
12 tasks
@rubentalstra
Copy link
Collaborator

I have created a merge request with apple auth implement and fully working.

justinmdickey pushed a commit to e-gineering/LibreChat that referenced this issue Feb 7, 2025
* implemented Apple Auth login.

Closes: danny-avila#3438

TODO:
- write config Doc

* removed some comments

* removed comment

* Add unit tests for Apple login strategy

Introduce comprehensive tests for the Apple login strategy, covering new user creation, existing user updates, and error handling scenarios during the authentication flow. Mocks implemented for external dependencies to ensure isolated testing.

* Remove unnecessary blank line in socialLogins.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants