Invalid nested bool query with more "query", but works with "filter"

[piotrkochan]

Example code:

const bodybuilder = require('bodybuilder');
let body = bodybuilder();

body.query('bool', b => b
      .filter('term', 'field1', x)
      .filter('term', 'field2', x)
      .orFilter('term', 'field3', x));
body.query('bool', b => b
      .filter('term', 'field1', x)
      .filter('term', 'field2', x)
      .orFilter('term', 'field3', x));

Makes perfect, valid query:

{
  "query": {
    "bool": {
      "must": [
        {
          "bool": {
            "filter": {
              "bool": {
                "must": [
                  {
                    "term": {
                      "field1": 1
                    }
                  },
                  {
                    "term": {
                      "field2": 2
                    }
                  }
                ],
                "should": [
                  {
                    "term": {
                      "field3": 3
                    }
                  }
                ]
              }
            }
          }
        },
        {
          "bool": {
            "filter": {
              "bool": {
                "must": [
                  {
                    "term": {
                      "field4": 10
                    }
                  },
                  {
                    "term": {
                      "field5": 20
                    }
                  }
                ],
                "should": [
                  {
                    "term": {
                      "field6": 30
                    }
                  }
                ]
              }
            }
          }
        }
      ]
    }
  }
}

Change filters to queries:

const bodybuilder = require('bodybuilder');
let body = bodybuilder();

body.query('bool', b => b
      .query('term', 'field1', x)
      .query('term', 'field2', x)
      .orQuery('term', 'field3', x));
body.query('bool', b => b
      .query('term', 'field1', x)
      .query('term', 'field2', x)
      .orQuery('term', 'field3', x));

And built query is invalid:

{
    "error": {
        "root_cause": [
            {
                "type": "parsing_exception",
                "reason": "[bool] query does not support [query]",
                "line": 7,
                "col": 22
            }
        ],
        "type": "parsing_exception",
        "reason": "[bool] query does not support [query]",
        "line": 7,
        "col": 22
    },
    "status": 400
}

{
  "query": {
    "bool": {
      "must": [
        {
          "bool": {
            "query": {
              "bool": {
                "must": [
                  {
                    "term": {
                      "field1": 1
                    }
                  },
                  {
                    "term": {
                      "field2": 2
                    }
                  },
                  {
                    "term": {
                      "field3": 3
                    }
                  }
                ]
              }
            }
          }
        },
        {
          "bool": {
            "query": {
              "bool": {
                "must": [
                  {
                    "term": {
                      "field4": 10
                    }
                  },
                  {
                    "term": {
                      "field5": 20
                    }
                  },
                  {
                    "term": {
                      "field6": 30
                    }
                  }
                ]
              }
            }
          }
        }
      ]
    }
  }
}

[johannes-scharlach]

I've had a go at this in #144, but the current solution would be a breaking change to people using nested, has_parent or has_child with elasticsearch version 1.x.

If you need this change quickly, you can fork my branch and build it for yourself or help with making the change backwards-compatible :) (All tests would need to pass)

[i-like-robots]

I've also just stumbled into this problem too, unfortunately =[

[piotrkochan]

I've already moved to https://github.com/sudo-suhas/elastic-builder

[johannes-scharlach]

You can always specify the raw query syntax if something isn't supported. That's not optimal, but works all the time. Example:

bodybuilder()
  .query("bool", {
    must: [
      {
        term: {
          field1: 1
        }
      },
      {
        term: {
          field2: 2
        }
      }
    ],
    should: [
      {
        term: {
          field3: 3
        }
      }
    ]
  })
  .query("bool", {
    must: [
      {
        term: {
          field4: 10
        }
      },
      {
        term: {
          field5: 20
        }
      }
    ],
    should: [
      {
        term: {
          field6: 30
        }
      }
    ]
  })
  .build();

This would produce the query @piotrkochan was aiming for.

[piotrkochan]

Of course I could but this make no sense. The point of use libraries like bodybuilder is to do not write raw queries. Still it is really good to build simple queries.

[johannes-scharlach]

Sure, it would be better if we could merge #144. If you're interested in contributing, I can help point you to the pieces of code that would need to be changed to make the tests pass.