Functions' visibility

[pauliax]

Consider marking functions with a specific access level, for example, functions that aren't called internally, please mark with a keyword "external". Calling external function consumes less gas than public function. Also, functions that are only used internally, should be marked "internal". If you want, I can specify which modifier every function should have.
As for best practices, you should use external if you expect that the function will only ever be called externally, and use public if you also need to call this function internally.

Now, in your code ~90% of the functions are public, despite some of them are only called from the outside world.

[dete]

Thanks @pauliax, this is very helpful.

For anyone interested in more details: https://ethereum.stackexchange.com/questions/19380/external-vs-public-best-practices

[kimcope]

Thanks for your participation, @pauliax! Our team has reviewed your submission, and we are pleased to reward you for your report.

Impact: Low
Likelihood: Medium
Points: 125

Please see the final leaderboard here.