Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When kitty gives birth in the ownership of SaleClockAuction, offspring becomes locked #19

Open
adamkolar opened this issue Nov 19, 2017 · 2 comments

Comments

@adamkolar
Copy link

If birth happens while the kitty is in the ownership of SaleClockAuction contract, the offspring stays in the ownership of the auction contract indefinitely.
As a solution, I propose adding require to giveBirth function that checks if the current owner isn't SaleClockAuction contract, second option is preventing pregnant kitties from being put up for sale.

@dete
Copy link

dete commented Nov 19, 2017

Excellent catch, @adamkolar! Our intention was to prevent pregnant Kitties from being put up for auction, but we aren't actually checking for it. Very nice find, thank you!

@kimcope
Copy link
Contributor

kimcope commented Nov 21, 2017

Thanks for your participation, @adamkolar! Our team has reviewed your submission, and we are pleased to reward you for your report.

Impact: Medium
Likelihood: Low
Points: 125

Please see the final leaderboard here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants