Skip to content

Commit fc8636d

Browse files
shivamkm07Shivam Kumar
and
Shivam Kumar
authored
Fix Redis EntraId Token Refresh (#3632)
Signed-off-by: Shivam Kumar <[email protected]> Co-authored-by: Shivam Kumar <[email protected]>
1 parent 026ae76 commit fc8636d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

common/component/redis/redis.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -214,21 +214,21 @@ func ParseClientFromProperties(properties map[string]string, componentType metad
214214
// start the token refresh goroutine
215215

216216
if settings.UseEntraID {
217-
StartEntraIDTokenRefreshBackgroundRoutine(c, settings.Username, *tokenExpires, tokenCredential, ctx, logger)
217+
StartEntraIDTokenRefreshBackgroundRoutine(c, settings.Username, *tokenExpires, tokenCredential, logger)
218218
}
219219
return c, &settings, nil
220220
}
221221

222-
func StartEntraIDTokenRefreshBackgroundRoutine(client RedisClient, username string, nextExpiration time.Time, cred *azcore.TokenCredential, parentCtx context.Context, logger *kitlogger.Logger) {
222+
func StartEntraIDTokenRefreshBackgroundRoutine(client RedisClient, username string, nextExpiration time.Time, cred *azcore.TokenCredential, logger *kitlogger.Logger) {
223223
go func(cred *azcore.TokenCredential, username string, logger *kitlogger.Logger) {
224-
ctx, cancel := context.WithCancel(parentCtx)
224+
ctx, cancel := context.WithCancel(context.Background())
225225
defer cancel()
226226
backoffConfig := kitretry.DefaultConfig()
227227
backoffConfig.MaxRetries = 3
228228
backoffConfig.Policy = kitretry.PolicyExponential
229229

230230
var backoffManager backoff.BackOff
231-
const refreshGracePeriod = 2 * time.Minute
231+
const refreshGracePeriod = 5 * time.Minute
232232
tokenRefreshDuration := time.Until(nextExpiration.Add(-refreshGracePeriod))
233233

234234
(*logger).Debugf("redis client: starting entraID token refresh loop")

0 commit comments

Comments
 (0)