Skip to content

Commit 61918a6

Browse files
committed
review: Use ctx.getLogger
Signed-off-by: Javier Aliaga <[email protected]>
1 parent fa8f3fb commit 61918a6

File tree

1 file changed

+25
-22
lines changed
  • examples/src/main/java/io/dapr/examples/workflows

1 file changed

+25
-22
lines changed

examples/src/main/java/io/dapr/examples/workflows/README.md

Lines changed: 25 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -692,18 +692,19 @@ public class CrossAppWorkflow implements Workflow {
692692
@Override
693693
public WorkflowStub create() {
694694
return ctx -> {
695-
ctx.getLogger().info("=== WORKFLOW STARTING ===");
696-
ctx.getLogger().info("Starting CrossAppWorkflow: " + ctx.getName());
697-
ctx.getLogger().info("Workflow name: " + ctx.getName());
698-
ctx.getLogger().info("Workflow instance ID: " + ctx.getInstanceId());
695+
var logger = ctx.getLogger();
696+
logger.info("=== WORKFLOW STARTING ===");
697+
logger.info("Starting CrossAppWorkflow: {}", ctx.getName());
698+
logger.info("Workflow name: {}", ctx.getName());
699+
logger.info("Workflow instance ID: {}", ctx.getInstanceId());
699700

700701
String input = ctx.getInput(String.class);
701-
ctx.getLogger().info("CrossAppWorkflow received input: " + input);
702-
ctx.getLogger().info("Workflow input: " + input);
702+
logger.info("CrossAppWorkflow received input: {}", input);
703+
logger.info("Workflow input: {}", input);
703704

704705
// Call an activity in another app by passing in an active appID to the WorkflowTaskOptions
705-
ctx.getLogger().info("Calling cross-app activity in 'app2'...");
706-
ctx.getLogger().info("About to call cross-app activity in app2...");
706+
logger.info("Calling cross-app activity in 'app2'...");
707+
logger.info("About to call cross-app activity in app2...");
707708
String crossAppResult = ctx.callActivity(
708709
App2TransformActivity.class.getName(),
709710
input,
@@ -712,19 +713,19 @@ public class CrossAppWorkflow implements Workflow {
712713
).await();
713714

714715
// Call another activity in a different app
715-
ctx.getLogger().info("Calling cross-app activity in 'app3'...");
716-
ctx.getLogger().info("About to call cross-app activity in app3...");
716+
logger.info("Calling cross-app activity in 'app3'...");
717+
logger.info("About to call cross-app activity in app3...");
717718
String finalResult = ctx.callActivity(
718719
App3FinalizeActivity.class.getName(),
719720
crossAppResult,
720721
new WorkflowTaskOptions("app3"),
721722
String.class
722723
).await();
723-
ctx.getLogger().info("Final cross-app activity result: " + finalResult);
724-
ctx.getLogger().info("Final cross-app activity result: " + finalResult);
724+
logger.info("Final cross-app activity result: {}", finalResult);
725+
logger.info("Final cross-app activity result: {}", finalResult);
725726

726-
ctx.getLogger().info("CrossAppWorkflow finished with: " + finalResult);
727-
ctx.getLogger().info("=== WORKFLOW COMPLETING WITH: " + finalResult + " ===");
727+
logger.info("CrossAppWorkflow finished with: {}", finalResult);
728+
logger.info("=== WORKFLOW COMPLETING WITH: {} ===" , finalResult);
728729
ctx.complete(finalResult);
729730
};
730731
}
@@ -737,14 +738,15 @@ The `App2TransformActivity` class defines an activity in app2 that transforms th
737738
public class App2TransformActivity implements WorkflowActivity {
738739
@Override
739740
public Object run(WorkflowActivityContext ctx) {
740-
System.out.println("=== App2: TransformActivity called ===");
741+
var logger = ctx.getLogger();
742+
logger.info("=== App2: TransformActivity called ===");
741743
String input = ctx.getInput(String.class);
742-
System.out.println("Input: " + input);
744+
logger.info("Input: {}", input);
743745

744746
// Transform the input
745747
String result = input.toUpperCase() + " [TRANSFORMED BY APP2]";
746-
747-
System.out.println("Output: " + result);
748+
749+
logger.info("Output: {}", result);
748750
return result;
749751
}
750752
}
@@ -755,14 +757,15 @@ The `App3FinalizeActivity` class defines an activity in app3 that finalizes the
755757
public class App3FinalizeActivity implements WorkflowActivity {
756758
@Override
757759
public Object run(WorkflowActivityContext ctx) {
758-
System.out.println("=== App3: FinalizeActivity called ===");
760+
var logger = ctx.getLogger();
761+
logger.info("=== App3: FinalizeActivity called ===");
759762
String input = ctx.getInput(String.class);
760-
System.out.println("Input: " + input);
763+
logger.info("Input: ", input);
761764

762765
// Finalize the processing
763766
String result = input + " [FINALIZED BY APP3]";
764-
765-
System.out.println("Output: " + result);
767+
768+
logger.info("Output: {}", result);
766769
return result;
767770
}
768771
}

0 commit comments

Comments
 (0)