Skip to content

Commit b962ce7

Browse files
committed
chore: more review comments fixes
Signed-off-by: Javier Aliaga <[email protected]>
1 parent bd84b7d commit b962ce7

File tree

4 files changed

+8
-13
lines changed

4 files changed

+8
-13
lines changed

sdk-tests/src/test/java/io/dapr/it/testcontainers/workflows/crossapp/App2TransformActivity.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ public class App2TransformActivity implements WorkflowActivity {
2626
public Object run(WorkflowActivityContext ctx) {
2727
String input = ctx.getInput(String.class);
2828
logger.info("=== App2: TransformActivity called ===");
29-
logger.info("Input: " + input);
29+
logger.info("Input: {}", input);
3030

3131
String output = input.toUpperCase() + " [TRANSFORMED BY APP2]";
32-
logger.info("Output: " + output);
32+
logger.info("Output: {}", output);
3333

3434
return output;
3535
}

sdk-tests/src/test/java/io/dapr/it/testcontainers/workflows/crossapp/App3FinalizeActivity.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ public class App3FinalizeActivity implements WorkflowActivity {
2626
public Object run(WorkflowActivityContext ctx) {
2727
String input = ctx.getInput(String.class);
2828
logger.info("=== App3: FinalizeActivity called ===");
29-
logger.info("Input: " + input);
29+
logger.info("Input: {}", input);
3030

3131
String output = input + " [FINALIZED BY APP3]";
32-
logger.info("Output: " + output);
32+
logger.info("Output: {}", output);
3333

3434
return output;
3535
}

sdk-tests/src/test/java/io/dapr/it/testcontainers/workflows/crossapp/CrossAppWorkflow.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,16 @@
1919
import org.slf4j.Logger;
2020

2121
public class CrossAppWorkflow implements Workflow {
22-
23-
24-
2522
@Override
2623
public WorkflowStub create() {
2724
return ctx -> {
2825
Logger logger = ctx.getLogger();
2926
String instanceId = ctx.getInstanceId();
30-
logger.info("Starting CrossAppWorkflow: " + ctx.getName());
31-
logger.info("Instance ID: " + instanceId);
27+
logger.info("Starting CrossAppWorkflow: {}", ctx.getName());
28+
logger.info("Instance ID: {}", instanceId);
3229

3330
String input = ctx.getInput(String.class);
34-
logger.info("Workflow input: " + input);
31+
logger.info("Workflow input: {}", input);
3532

3633
// Call App2TransformActivity in app2
3734
logger.info("Calling cross-app activity in 'app2'...");
@@ -51,7 +48,7 @@ public WorkflowStub create() {
5148
String.class
5249
).await();
5350

54-
logger.info("Final cross-app activity result: " + finalizedByApp3);
51+
logger.info("Final cross-app activity result: {}", finalizedByApp3);
5552
ctx.complete(finalizedByApp3);
5653
};
5754
}

sdk-tests/src/test/java/io/dapr/it/testcontainers/workflows/crossapp/WorkflowsCrossAppCallActivityIT.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,6 @@ public void testCrossAppWorkflow() throws Exception {
224224
// The workers use host.testcontainers.internal:50001, so we need to use the mapped port
225225
String grpcEndpoint = "localhost:" + MAIN_WORKFLOW_CONTAINER.getMappedPort(50001);
226226
String httpEndpoint = "localhost:" + MAIN_WORKFLOW_CONTAINER.getMappedPort(3500);
227-
System.setProperty("dapr.grpc.endpoint", grpcEndpoint);
228-
System.setProperty("dapr.http.endpoint", httpEndpoint);
229227
Map<String, String> propertyOverrides = Map.of(
230228
"dapr.grpc.endpoint", grpcEndpoint,
231229
"dapr.http.endpoint", httpEndpoint

0 commit comments

Comments
 (0)