Skip to content

Commit 6229c18

Browse files
authored
fix: collection filtering condition (#13)
1 parent 01c8a3b commit 6229c18

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

.changeset/yellow-wolves-invent.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"mikro-orm-find-dataloader": patch
3+
---
4+
5+
fix: collection filtering condition

packages/find/src/findDataloader.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,9 @@ export function getFindBatchLoadFn<Entity extends object>(
490490
} else {
491491
// Our current filter is an object
492492
if (entityValue instanceof Collection) {
493-
entityValue.find((entity) => filterResult(entity, value));
493+
if (!entityValue.getItems().some((entity) => filterResult(entity, value))) {
494+
return false;
495+
}
494496
} else if (!filterResult(entityValue as object, value)) {
495497
return false;
496498
}

0 commit comments

Comments
 (0)