Skip to content

Commit a1a0fff

Browse files
authored
fix: compatibility with latest mikro-orm alphas (#1)
1 parent a4bf086 commit a1a0fff

File tree

6 files changed

+257
-268
lines changed

6 files changed

+257
-268
lines changed

.changeset/smooth-lies-scream.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"mikro-orm-find-dataloader": patch
3+
---
4+
5+
Compatibility with latest MikroORM alphas which export different types

examples/graphql/package.json

+7-7
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@
1616
"test": "yarn run build"
1717
},
1818
"dependencies": {
19-
"@mikro-orm/cli": "6.0.0-dev.187",
20-
"@mikro-orm/core": "6.0.0-dev.187",
21-
"@mikro-orm/entity-generator": "6.0.0-dev.187",
22-
"@mikro-orm/knex": "6.0.0-dev.187",
23-
"@mikro-orm/migrations": "6.0.0-dev.187",
24-
"@mikro-orm/reflection": "6.0.0-dev.187",
25-
"@mikro-orm/sqlite": "6.0.0-dev.187",
19+
"@mikro-orm/cli": "6.0.0-dev.220",
20+
"@mikro-orm/core": "6.0.0-dev.220",
21+
"@mikro-orm/entity-generator": "6.0.0-dev.220",
22+
"@mikro-orm/knex": "6.0.0-dev.220",
23+
"@mikro-orm/migrations": "6.0.0-dev.220",
24+
"@mikro-orm/reflection": "6.0.0-dev.220",
25+
"@mikro-orm/sqlite": "6.0.0-dev.220",
2626
"graphql": "16.8.1",
2727
"graphql-yoga": "5.0.0",
2828
"tslib": "2.6.2"

package.json

+7-7
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@
2525
"@changesets/changelog-github": "^0.4.8",
2626
"@changesets/cli": "^2.26.2",
2727
"@types/eslint": "^8.44.7",
28-
"@types/jest": "^29.5.8",
29-
"@types/node": "^20.9.1",
30-
"@typescript-eslint/eslint-plugin": "^6.11.0",
28+
"@types/jest": "^29.5.10",
29+
"@types/node": "^20.10.0",
30+
"@typescript-eslint/eslint-plugin": "^6.12.0",
3131
"eslint": "^8.54.0",
3232
"eslint-config-prettier": "^9.0.0",
3333
"eslint-config-standard-with-typescript": "^40.0.0",
@@ -44,11 +44,11 @@
4444
"rimraf": "^5.0.5",
4545
"ts-jest": "^29.1.1",
4646
"ts-node": "^10.9.1",
47-
"typescript": "^5.2.2"
47+
"typescript": "^5.3.2"
4848
},
4949
"lint-staged": {
50-
"*.ts": [
51-
"eslint \"packages/**/*.ts\" \"examples/**/*.ts\" --fix"
52-
]
50+
"*.{js,jsx}": ["prettier --write", "eslint --fix --quiet --config .eslintrc.js --resolve-plugins-relative-to .", "git add"],
51+
"*.{ts,tsx}": ["prettier --write", "eslint --fix --quiet --config .eslintrc.js --resolve-plugins-relative-to .", "git add"],
52+
"*.{scss,scss,css,md,html}": ["prettier --write", "git add"]
5353
}
5454
}

packages/find/package.json

+6-3
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,17 @@
3939
"testEnvironment": "node",
4040
"preset": "ts-jest",
4141
"collectCoverage": true,
42-
"testPathIgnorePatterns": ["/node_modules/", "/dist/"]
42+
"testPathIgnorePatterns": [
43+
"/node_modules/",
44+
"/dist/"
45+
]
4346
},
4447
"publishConfig": {
4548
"access": "public"
4649
},
4750
"devDependencies": {
48-
"@mikro-orm/core": "6.0.0-dev.187",
49-
"@mikro-orm/sqlite": "6.0.0-dev.187"
51+
"@mikro-orm/core": "6.0.0-dev.220",
52+
"@mikro-orm/sqlite": "6.0.0-dev.220"
5053
},
5154
"peerDependencies": {
5255
"@mikro-orm/core": "^6.0.0"

packages/find/src/EntityDataLoader.ts

+11-6
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,24 @@ import {
1212
type EntityName,
1313
type EntityKey,
1414
type Loaded,
15+
type EntityProps,
16+
type ExpandProperty,
17+
type ExpandScalar,
18+
type FilterItemValue,
19+
type ExpandQuery,
20+
type Scalar,
1521
} from "@mikro-orm/core";
1622
import DataLoader from "dataloader";
1723
import { type DataloaderFind, groupFindQueries, assertHasNewFilterAndMapKey } from "./findDataloader";
18-
import type { EntityProps, ExpandProperty, ExpandScalar, FilterValue2, Query, Scalar } from "@mikro-orm/core/typings";
1924

2025
export interface OperatorMapDataloader<T> {
21-
// $and?: Query<T>[];
22-
$or?: Array<Query<T>>;
26+
// $and?: ExpandQuery<T>[];
27+
$or?: Array<ExpandQuery<T>>;
2328
// $eq?: ExpandScalar<T> | ExpandScalar<T>[];
2429
// $ne?: ExpandScalar<T>;
2530
// $in?: ExpandScalar<T>[];
2631
// $nin?: ExpandScalar<T>[];
27-
// $not?: Query<T>;
32+
// $not?: ExpandQuery<T>;
2833
// $gt?: ExpandScalar<T>;
2934
// $gte?: ExpandScalar<T>;
3035
// $lt?: ExpandScalar<T>;
@@ -40,8 +45,8 @@ export interface OperatorMapDataloader<T> {
4045
}
4146

4247
export type FilterValueDataloader<T> =
43-
/* OperatorMapDataloader<FilterValue2<T>> | */
44-
FilterValue2<T> | FilterValue2<T>[] | null;
48+
/* OperatorMapDataloader<FilterItemValue<T>> | */
49+
FilterItemValue<T> | FilterItemValue<T>[] | null;
4550

4651
export type QueryDataloader<T> = T extends object
4752
? T extends Scalar

0 commit comments

Comments
 (0)