Plan for 5.6.2

[TurboGit]

I think we are going to have a 5.6.2 at least for the Windows users. Let's plan this for early October.

If you want some ultra-safe fix in master to be merged in 5.6.x branch, please let's discuss that.

@victoryforce @andriiryzhkov @jenshannoschwalm @rtmongold @Arecsu @anoderay @kofa73 @wpferguson

[anoderay]

That's great news. I think this PR would make sense to consider for inclusion #22337.

[TurboGit]

Yes, hopefully this PR will get tested / reviewed by a Windows dev soon.

[jenshannoschwalm]

I think the opencl bugfixes about aliasing in&out should be included. You want a dedicated PR?

[TurboGit]

Yes, except if it applies on 5.6 cleanly. Just give me the commit sha-1 for the code change and the one for the release notes and I'll see.

[jenshannoschwalm]

4c5cf10
db0c115

Likely also
9242e21
994efc3

[TurboGit]

All merged in 5.6.x branch.

[wpferguson]

I don't have anything for 5.6.2

[kofa73]

Irrelevant (5.7 regressions)
Maybe
#21725 (a crash)
#21816 (a freeze)

[TurboGit]

#21725 (a crash) does not apply in 5.6.x. Could you create a PR for the branch?

[TurboGit]

#21816 (a freeze) likewise

[victoryforce]

#21960 from me, for sure (fixes a crash that was reported multiple times in the issues). #22031 might resolve an issue users were encountering, although the fix isn't based on an analysis of a specific issue report.

My other fixes that could have prevented crashes are mostly correct handling of memory allocation failures, so they are not very critical as they address rare situations.

[TurboGit]

Both PR merged.

[zisoft]

#22354 : Fixes transparent dialog title bars on macOS

[TurboGit]

Merged.

[kofa73]

Sorry about the noise: neither #21725, nor #21816 is relevant - both fix regressions introduced on 5.7.

[TurboGit]

No problem.

[andriiryzhkov]

From my side, small and applying cleanly on 5.6.x:

• Fix crash importing a style with an empty iop_list #22200 (crash importing a style with empty module order)
• Fix neural restore raw denoise crash on some sensor sizes #22035 (neural restore raw denoise crash on some sensor sizes)
• Fix segmentation preprocessing to pixel-centre sampling #21797 (AI segmentation mask offset)
• Fix two memory leaks in variable expansion #22219 (variable expansion leaks)
• control: free the history job data when no job takes it over #22147 (history paste job leak)

Larger, also clean and string-free, your call on the size:

• Fix Windows backslash paths in export and import #22143 (Windows backslash paths in export/import, 113 lines over 9 files), relevant for a Windows release
• Fix ONNX Runtime probe crash on Windows #22139 (ORT probe thread-scoped, resources released on recovery, 173 lines in one file), follow-up to the probe crash fix already in 5.6.1
• Fix out-of-bounds writes in the AI backend's output copy #22173 (AI output buffer overflow guard, 151 lines over 5 files)

[TurboGit]

Thanks @andriiryzhkov, I have merged every PR except : #22143 (too large and a fix for something not common).

[andriiryzhkov]

@TurboGit: just curious, are you updating RawSpeed with new release too?

[kmilos]

will bump again just before the 5.6.2 release if needed

TBH, not sure when or who will merge those waiting PRs (970, 976, 980, 982, 984, 989, 990, 991, 992, 993 as of this moment) until then... Current changes on develop are only a few (welcome nonetheless).

[TurboGit]

@kmilos : I could merge this, but not sure if merging blindly is a good thing and I have no more free time.

What else can I do to help?

I can give you the proper permissions to merge those PR, would that be ok? We probably want to discuss this with @LebedevRI.

Anyway, let me know if I can be of any help to unblock this situation until RsRS is ready.

[kmilos]

I can give you the proper permissions to merge those PR, would that be ok?

Thanks Pascal, but no thanks.

[victoryforce]

I could merge this, but not sure if merging blindly is a good thing and I have no more free time.

@TurboGit - Could I ask you to merge all the pending PRs you mentioned above? Support for new cameras uses the matrix from Adobe DNG Convertor, there is no room for erroneous data here (the contributor doesn't measure anything), we accept what Adobe considers correct. The only aspect where it is worth evaluating raw file samples with your own eyes is the crop offsets. In this regard, I fully trust the experience of Miloš, who has made many similar contributions.

If you insist that this needs to be reviewed, I can do so and verify that everything works correctly using the available raw samples.

I would prefer not to make users wait unnecessarily for new camera support that is already available, simply due to processing delays in the rawspeed repository.

[TurboGit]

@victoryforce @LebedevRI : Ok, I'll start merging the trivial PR starting next week. I agree with @victoryforce this is important for the project, we really need to move forward.

[TurboGit]

FYI: 5.6.2 will be released tomorrow. Thanks all for helping on this release.

[andriiryzhkov]

JFYI: AI models release index is ready for 5.6.2.