Skip to content
This repository was archived by the owner on Oct 18, 2024. It is now read-only.

Commit b75cba7

Browse files
authored
blast_repo fixes (#137)
* blast_repo fixes no-response * update analysis and test matrix
1 parent 4779d7e commit b75cba7

File tree

6 files changed

+18
-38
lines changed

6 files changed

+18
-38
lines changed

.github/workflows/no-response.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ on:
88
issue_comment:
99
types: [created]
1010
schedule:
11-
# Schedule for five minutes after the hour, every hour
12-
- cron: '5 * * * *'
11+
# Every day at 8am
12+
- cron: '0 8 * * *'
1313

1414
# All permissions not specified are set to 'none'.
1515
permissions:
@@ -27,8 +27,8 @@ jobs:
2727
daysUntilClose: 14
2828
# Comment to post when closing an Issue for lack of response.
2929
closeComment: >
30-
Without additional information we're not able to resolve this
31-
issue, so it will be closed at this time. You're still free to add
32-
more info and respond to any questions above, though. We'll reopen
33-
the case if you do. Thanks for your contribution!
30+
Without additional information we're not able to resolve this issue,
31+
so it will be closed at this time. You're still free to add more
32+
info and respond to any questions above, though. We'll reopen the
33+
issue if you do. Thanks for your contribution!
3434
token: ${{ github.token }}

.github/workflows/test-package.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,13 @@ env:
1313
PUB_ENVIRONMENT: bot.github
1414

1515
jobs:
16-
# Check code formatting and static analysis on a single OS (linux)
17-
# against Dart dev.
16+
# Check code formatting and static analysis.
1817
analyze:
1918
runs-on: ubuntu-latest
2019
strategy:
2120
fail-fast: false
2221
matrix:
23-
sdk: [dev]
22+
sdk: [stable]
2423
steps:
2524
- uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
2625
- uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
@@ -36,9 +35,7 @@ jobs:
3635
run: dart analyze --fatal-infos
3736
if: always() && steps.install.outcome == 'success'
3837

39-
# Run tests on a matrix consisting of two dimensions:
40-
# 1. OS: ubuntu-latest, (macos-latest, windows-latest)
41-
# 2. release channel: dev
38+
# Run tests on a matrix of platforms and sdk versions.
4239
test:
4340
needs: analyze
4441
runs-on: ${{ matrix.os }}
@@ -47,7 +44,7 @@ jobs:
4744
matrix:
4845
# Add macos-latest and/or windows-latest if relevant for this package.
4946
os: [ubuntu-latest]
50-
sdk: [2.18.0, dev]
47+
sdk: [2.19.0, stable, beta]
5148
steps:
5249
- uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
5350
- uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 1.1.2-wip
2+
3+
* Require Dart 2.19.
4+
15
## 1.1.1
26

37
* Add a check that throws if a logger name ends with '.'.

analysis_options.yaml

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,54 +1,36 @@
11
# https://dart.dev/guides/language/analysis-options
2-
include: package:lints/recommended.yaml
2+
include: package:dart_flutter_team_lints/analysis_options.yaml
33

44
analyzer:
55
language:
6-
strict-casts: true
76
strict-raw-types: true
87

98
linter:
109
rules:
11-
- always_declare_return_types
1210
- avoid_bool_literals_in_conditional_expressions
13-
- avoid_catching_errors
1411
- avoid_classes_with_only_static_members
15-
- avoid_dynamic_calls
1612
- avoid_private_typedef_functions
1713
- avoid_redundant_argument_values
18-
- avoid_returning_null
1914
- avoid_returning_null_for_future
2015
- avoid_returning_this
2116
- avoid_unused_constructor_parameters
2217
- avoid_void_async
2318
- cancel_subscriptions
2419
- comment_references
25-
- directives_ordering
2620
- join_return_with_assignment
27-
- lines_longer_than_80_chars
2821
- literal_only_boolean_expressions
2922
- missing_whitespace_between_adjacent_strings
3023
- no_adjacent_strings_in_list
3124
- no_runtimeType_toString
32-
- omit_local_variable_types
33-
- only_throw_errors
3425
- package_api_docs
35-
- prefer_asserts_in_initializer_lists
3626
- prefer_const_constructors
3727
- prefer_const_declarations
3828
- prefer_expression_function_bodies
3929
- prefer_final_locals
4030
- prefer_relative_imports
41-
- prefer_single_quotes
42-
- sort_pub_dependencies
4331
- test_types_in_equals
44-
- throw_in_finally
45-
- type_annotate_public_apis
46-
- unawaited_futures
4732
- unnecessary_await_in_return
48-
- unnecessary_lambdas
49-
- unnecessary_parenthesis
5033
- unnecessary_raw_strings
51-
- unnecessary_statements
5234
- use_if_null_to_convert_nulls_to_bools
5335
- use_raw_strings
5436
- use_string_buffers

pubspec.yaml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
11
name: logging
2-
version: 1.1.1
3-
2+
version: 1.1.2-wip
43
description: >-
54
Provides APIs for debugging and error logging, similar to loggers in other
65
languages, such as the Closure JS Logger and java.util.logging.Logger.
76
repository: https://github.com/dart-lang/logging
87

98
environment:
10-
sdk: ">=2.18.0 <3.0.0"
9+
sdk: '>=2.19.0 <4.0.0'
1110

1211
dev_dependencies:
13-
lints: ^2.0.0
12+
dart_flutter_team_lints: ^1.0.0
1413
test: ^1.16.0

test/logging_test.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
library logging_test;
6-
75
import 'dart:async';
86

97
import 'package:logging/logging.dart';

0 commit comments

Comments
 (0)