[linter] identical_if_branch

[stephane-archer]

int foo(int i)
{
    if (i ==42) { // useless if
        print(i);
       return i;
    }
    print(i);
    return i;
}

[FMorschel]

Somewhat similar to #59529

[stephane-archer]

@FMorschel not exactly

[FMorschel]

@stephane-archer I didn't say they are dupes, I only said they are similar in the request but for different cases. I only try to mention similar issues together in case someone else finds them in the future they can follow anything similar if they want to. I found some cases, if not here in other repos, where similar issues can be resolved together or can inspire one another in small tweaks or features.

In this case, both our issues are trying to solve the issue of having duplicate code inside a block where it could be detected by a lint rather than the programmer.

[stephane-archer]

@FMorschel I see your point.

Some maintainers (the Flutter team) tend to mark everything as duplicates to reduce the number of tickets (apparently they have the incentive to close issues rather than solve them) which is why I was quite defensive.

[pq]

@bwilkerson has done some thinking about detecting duplication