Skip to content
This repository has been archived by the owner on Mar 28, 2022. It is now read-only.

Remove Microphone access request #7

Open
jeremyjs opened this issue Aug 8, 2020 · 4 comments
Open

Remove Microphone access request #7

jeremyjs opened this issue Aug 8, 2020 · 4 comments

Comments

@jeremyjs
Copy link

jeremyjs commented Aug 8, 2020

Is the microphone access necessary for some reason? Causes weird audio issues for me on MacOS Chrome in addition to being an unnecessary security vector.

I can take a look at making a PR if this is an approved improvement.

@reenan
Copy link

reenan commented Dec 9, 2020

any update on this request? please let's remove this :(

@glenkleidon
Copy link

Yes, Can I please ad my vote. There should be no need to enable the microphone. It probably a switch in the zxing library

@glenkleidon
Copy link

I believe I have it.

https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia#parameters

Video constraints can have the additional to properties { audio: false, video: true }

 return (
    <Webcam
      width={width}
      height={height}
      ref={webcamRef}
      screenshotFormat="image/png"
      videoConstraints={{
        facingMode: 'environment'
      }}
    />
  )

Becomes...

 return (
    <Webcam
      width={width}
      height={height}
      ref={webcamRef}
      screenshotFormat="image/png"
      videoConstraints={{
        facingMode: 'environment',
        audio: false, 
        video: true 
      }}
    />
  )

@glenkleidon
Copy link

glenkleidon commented Jan 21, 2021

submitted pull request. #12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants