feat(wallet-lib): ChainStore#196
Merged
Merged
Conversation
|
This pull request introduces 3 alerts when merging 009b365 into a846ce2 - view on LGTM.com new alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
In dashevo/wallet-lib#351, we introduced multiple features that couldn't be managed as is due to its size.
This PR is the least minimal of them concerning ChainStore (excluding the connection to Wallet-lib) itself.
ChainStore holds any information that is relatives to a specific network.
Information such as blockHeaders, transactions, instantLocks.
Also holds the state of addresses based on the transactions imported (e.g: balances and utxos).
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only