Skip to content

Commit 337f152

Browse files
authored
Fix flaky test_dump_cluster_unresponsive_remote_worker (#5679)
1 parent b341711 commit 337f152

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

distributed/tests/test_utils_test.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
import yaml
1111
from tornado import gen
1212

13+
import dask.config
14+
1315
from distributed import Client, Nanny, Scheduler, Worker, config, default_client
1416
from distributed.core import Server, rpc
1517
from distributed.metrics import time
@@ -100,11 +102,8 @@ async def test_gen_cluster_parametrized_variadic_workers(c, s, *workers, foo):
100102
)
101103
async def test_gen_cluster_set_config_nanny(c, s, a, b):
102104
def assert_config():
103-
import dask
104-
105105
assert dask.config.get("distributed.comm.timeouts.connect") == "1s"
106106
assert dask.config.get("new.config.value") == "foo"
107-
return dask.config
108107

109108
await c.run(assert_config)
110109
await c.run_on_scheduler(assert_config)
@@ -535,12 +534,11 @@ async def test_dump_cluster_state_unresponsive_local_worker(s, a, b, tmpdir):
535534
@gen_cluster(
536535
client=True,
537536
Worker=Nanny,
538-
config={"distributed.comm.timeouts.connect": "200ms"},
537+
config={"distributed.comm.timeouts.connect": "600ms"},
539538
)
540539
async def test_dump_cluster_unresponsive_remote_worker(c, s, a, b, tmpdir):
541-
addr1, addr2 = s.workers
542540
clog_fut = asyncio.create_task(
543-
c.run(lambda dask_scheduler: dask_scheduler.stop(), workers=[addr1])
541+
c.run(lambda dask_scheduler: dask_scheduler.stop(), workers=[a.worker_address])
544542
)
545543
await asyncio.sleep(0.2)
546544

@@ -549,7 +547,9 @@ async def test_dump_cluster_unresponsive_remote_worker(c, s, a, b, tmpdir):
549547
out = yaml.safe_load(fh)
550548

551549
assert out.keys() == {"scheduler", "workers", "versions"}
552-
assert isinstance(out["workers"][addr2], dict)
553-
assert out["workers"][addr1].startswith("OSError('Timed out trying to connect to")
550+
assert isinstance(out["workers"][b.worker_address], dict)
551+
assert out["workers"][a.worker_address].startswith(
552+
"OSError('Timed out trying to connect to"
553+
)
554554

555555
clog_fut.cancel()

0 commit comments

Comments
 (0)