Skip to content

distributed 2022.8.0 is breaking xarray tests #6842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dcherian opened this issue Aug 5, 2022 · 2 comments
Closed

distributed 2022.8.0 is breaking xarray tests #6842

dcherian opened this issue Aug 5, 2022 · 2 comments

Comments

@dcherian
Copy link

dcherian commented Aug 5, 2022

What happened:

Xarray test suite is broken.

E.g. https://github.com/pydata/xarray/runs/7699566983?check_suite_focus=true

I guess a fixture was renamed or removed?

[gw0] linux -- Python 3.10.5 /home/runner/micromamba/envs/xarray-tests/bin/python
file /home/runner/work/xarray/xarray/xarray/tests/test_distributed.py, line 132
  @pytest.mark.parametrize("engine,nc_format", ENGINES_AND_FORMATS)
  def test_dask_distributed_read_netcdf_integration_test(
file /home/runner/micromamba/envs/xarray-tests/lib/python3.10/site-packages/distributed/utils_test.py, line 119
  @pytest.fixture
  def loop(loop_in_thread):
E       fixture 'loop_in_thread' not found
>       available fixtures: add_standard_imports, backend, cache, capfd, capfdbinary, caplog, capsys, capsysbinary, cleanup, cov, da, doctest_namespace, ds, loop, monkeypatch, no_cover, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, testrun_uid, tmp_netcdf_filename, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, worker_id
>       use 'pytest --fixtures [testpath]' for help on them.

This is the test file that's failing

@jrbourbeau
Copy link
Member

Thanks @dcherian...PR incoming

@jrbourbeau
Copy link
Member

Closed via pydata/xarray#6884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants