FIX NPE

psainics · psainics · commit 553772f1be55 · 2025-04-29T10:38:19.000+05:30
diff --git a/src/main/java/io/cdap/plugin/MongoDBConfig.java b/src/main/java/io/cdap/plugin/MongoDBConfig.java
@@ -160,8 +160,9 @@ public void validate() {
     if (!containsMacro(MongoDBConstants.HOST) && Strings.isNullOrEmpty(host)) {
       throw new InvalidConfigPropertyException("Host must be specified", MongoDBConstants.HOST);
     }
-    if ((!containsMacro(MongoDBConstants.CONNECT_USING_SRV_STRING) && !connectUsingSRVString) &&
-      !containsMacro(MongoDBConstants.PORT)) {
+    if (!containsMacro(MongoDBConstants.PORT) && port != null && !containsMacro(
+        MongoDBConstants.CONNECT_USING_SRV_STRING) && connectUsingSRVString != null && !connectUsingSRVString) {
+      // Port is not required when SRV is used
       if (port < 1) {
         throw new InvalidConfigPropertyException("Port number must be greater than 0", MongoDBConstants.PORT);
       }

Original file line number	Diff line number	Diff line change
`@@ -160,8 +160,9 @@ public void validate() {`
`160`	`160`	`if (!containsMacro(MongoDBConstants.HOST) && Strings.isNullOrEmpty(host)) {`
`161`	`161`	`throw new InvalidConfigPropertyException("Host must be specified", MongoDBConstants.HOST);`
`162`	`162`	`}`
`163`		`- if ((!containsMacro(MongoDBConstants.CONNECT_USING_SRV_STRING) && !connectUsingSRVString) &&`
`164`		`- !containsMacro(MongoDBConstants.PORT)) {`
	`163`	`+ if (!containsMacro(MongoDBConstants.PORT) && port != null && !containsMacro(`
	`164`	`+ MongoDBConstants.CONNECT_USING_SRV_STRING) && connectUsingSRVString != null && !connectUsingSRVString) {`
	`165`	`+ // Port is not required when SRV is used`
`165`	`166`	`if (port < 1) {`
`166`	`167`	`throw new InvalidConfigPropertyException("Port number must be greater than 0", MongoDBConstants.PORT);`
`167`	`168`	`}`