fixes part 2 and clean up

Author: v-tarasevich-blitz-brain

datahub-web-react/src/alchemy-components/components/Breadcrumb/components.ts

@@ -1,3 +1,4 @@
+import { Divider } from 'antd';
 import { Link } from 'react-router-dom';
 import styled from 'styled-components';
 
@@ -30,3 +31,10 @@ export const BreadcrumbButton = styled(Text)`
         color: ${colors.primary[500]};
     }
 `;
+
+export const VerticalDivider = styled(Divider)`
+    color: ${colors.gray[100]};
+    height: 16px;
+    width: 2px;
+    margin: 0 4px;
+`;

datahub-web-react/src/alchemy-components/components/Checkbox/index.ts

@@ -1,3 +1,2 @@
 export { Checkbox, CheckboxGroup, checkboxDefaults } from './Checkbox';
-export { NativeCheckbox } from './NativeCheckbox';
 export type { CheckboxProps } from './types';

datahub-web-react/src/app/entityV2/shared/EntitySearchSelect/EntitySearchDropdown.tsx

@@ -169,10 +169,7 @@ export const EntitySearchDropdown: React.FC<EntitySearchDropdownProps> = ({
                 <Input
                     label=""
                     value={searchQuery}
-                    setValue={(value) => {
-                        const newValue = typeof value === 'function' ? value(searchQuery) : value;
-                        handleSearchChange(newValue);
-                    }}
+                    setValue={handleSearchChange}
                     placeholder={placeholder}
                     icon={{ icon: 'Search' }}
                     data-testid="entity-search-select-input"

datahub-web-react/src/app/ingestV2/hooks/useIngestionOnboardingRedesignV1.ts

@@ -2,5 +2,5 @@ import { useFeatureFlag } from '@app/sharedV2/hooks/useFeatureFlag';
 
 export function useIngestionOnboardingRedesignV1() {
     const ingestionOnboardingRedesignV1 = useFeatureFlag('ingestionOnboardingRedesignV1');
-    return ingestionOnboardingRedesignV1;
+    return !ingestionOnboardingRedesignV1;
 }

datahub-web-react/src/app/ingestV2/runDetails/IngestionRunDetailsPage.tsx

@@ -1,8 +1,8 @@
-import { Breadcrumb, colors } from '@components';
-import { Divider } from 'antd';
+import { Breadcrumb } from '@components';
 import React, { useEffect } from 'react';
 import { useLocation, useParams } from 'react-router';
-import styled from 'styled-components';
+
+import { VerticalDivider } from '@components/components/Breadcrumb/components';
 
 import RunDetailsContent from '@app/ingestV2/runDetails/RunDetailsContent';
 import { formatDateTime } from '@app/ingestV2/shared/components/columns/DateTimeColumn';
@@ -12,13 +12,6 @@ import { PageLayout } from '@app/sharedV2/layouts/PageLayout';
 
 import { useGetIngestionExecutionRequestQuery } from '@graphql/ingestion.generated';
 
-const VerticalDivider = styled(Divider)`
-    color: ${colors.gray[100]};
-    height: 16px;
-    width: 2px;
-    margin: 0 4px;
-`;
-
 export default function IngestionRunDetailsPage() {
     const { urn } = useParams<{ urn: string }>();
 

datahub-web-react/src/app/ingestV2/source/builder/IngestionSourceBuilderModal.tsx

@@ -11,11 +11,10 @@ import { DefineRecipeStep } from '@app/ingestV2/source/builder/DefineRecipeStep'
 import { NameSourceStep } from '@app/ingestV2/source/builder/NameSourceStep';
 import { SelectTemplateStep } from '@app/ingestV2/source/builder/SelectTemplateStep';
 import { SourceBuilderState, StepProps } from '@app/ingestV2/source/builder/types';
+import { useIngestionSources } from '@app/ingestV2/source/builder/useIngestionSources';
 
 import { IngestionSource } from '@types';
 
-import { useIngestionSources } from './useIngestionSources';
-
 const StepsContainer = styled.div`
     margin-right: 20px;
     margin-left: 20px;

datahub-web-react/src/app/ingestV2/source/builder/NameSourceStep.tsx

@@ -68,7 +68,7 @@ export const NameSourceStep = ({ state, updateState, prev, submit, isEditing, se
             setOwners(defaultActors);
             setAreOwnersInStateInitializedWhileCreation(true);
         }
-    }, [defaultActors, isEditing, me.loaded, areOwnersInStateInitializedWhileCreation]);
+    }, [defaultActors, isEditing, me.loaded, areOwnersInStateInitializedWhileCreation, setOwners]);
 
     const setExecutorId = (execId: string) => {
         const newState: SourceBuilderState = {

datahub-web-react/src/app/ingestV2/source/builder/RecipeForm/constants.ts

@@ -291,106 +291,6 @@ export const DEFAULT_DB: RecipeField = {
     placeholder: 'default_db',
     rules: [{ required: true, message: 'Default Database is required' }],
 };
-const dictFields = [PLATFORM, DEFAULT_DB];
-
-const testingFields: RecipeField[] = [
-    {
-        name: 'credential.TEXT',
-        label: 'TEXT',
-        helper: 'Text field for testing',
-        tooltip: "The Client ID, which can be found in your service account's JSON Key (client_id).",
-        placeholder: '123456789098765432101',
-        type: FieldType.TEXT,
-        fieldPath: 'source.config.TEXT',
-        rules: null,
-        required: true,
-    },
-    {
-        name: 'credential.TEXTAREA',
-        label: 'TEXTAREA',
-        helper: 'Textarea field for testing',
-        tooltip: "The Client ID, which can be found in your service account's JSON Key (client_id).",
-        placeholder: '123456789098765432101',
-        type: FieldType.TEXTAREA,
-        fieldPath: 'source.config.credential.TEXTAREA',
-        rules: null,
-        required: true,
-    },
-    {
-        name: 'credential.DATE',
-        label: 'DATE',
-        helper: 'Date field for testing',
-        tooltip: "The Client ID, which can be found in your service account's JSON Key (client_id).",
-        placeholder: '123456789098765432101',
-        type: FieldType.DATE,
-        fieldPath: 'source.config.credential.DATE',
-        rules: null,
-        required: true,
-    },
-    {
-        name: 'credential.BOOLEAN',
-        label: 'BOOLEAN',
-        helper: 'Boolean field for testing',
-        tooltip: "The Client ID, which can be found in your service account's JSON Key (client_id).",
-        placeholder: '123456789098765432101',
-        type: FieldType.BOOLEAN,
-        fieldPath: 'source.config.credential.BOOLEAN',
-        rules: null,
-        required: true,
-    },
-    {
-        name: 'credential.LIST',
-        label: 'LIST',
-        helper: 'List field for testing',
-        tooltip: "The Client ID, which can be found in your service account's JSON Key (client_id).",
-        placeholder: '123456789098765432101',
-        type: FieldType.LIST,
-        buttonLabel: 'Add test item',
-        fieldPath: 'source.config.credential.LIST',
-        rules: null,
-        required: true,
-    },
-    {
-        name: 'credential.SECRET',
-        label: 'SECRET',
-        helper: 'Secret field for testing',
-        tooltip: "The Client ID, which can be found in your service account's JSON Key (client_id).",
-        placeholder: '123456789098765432101',
-        type: FieldType.SECRET,
-        fieldPath: 'source.config.credential.SECRET',
-        rules: null,
-        required: true,
-    },
-    {
-        name: 'credential.DICT',
-        label: 'DICT',
-        helper: 'Dictionary field for testing',
-        tooltip: "The Client ID, which can be found in your service account's JSON Key (client_id).",
-        placeholder: '123456789098765432101',
-        type: FieldType.DICT,
-        buttonLabel: 'Add test mapping',
-        fieldPath: 'source.config.credential.DICT',
-        rules: null,
-        required: true,
-        fields: dictFields,
-    },
-    {
-        name: 'credential.SELECT',
-        label: 'SELECT',
-        helper: 'Select field for testing',
-        tooltip: "The Client ID, which can be found in your service account's JSON Key (client_id).",
-        placeholder: '123456789098765432101',
-        type: FieldType.SELECT,
-        fieldPath: 'source.config.credential.SELECT',
-        rules: null,
-        required: true,
-        options: [
-            { label: 'stl_scan_based', value: 'stl_scan_based' },
-            { label: 'sql_based', value: 'sql_based' },
-            { label: 'mixed', value: 'mixed' },
-        ],
-    },
-];
 
 export const RECIPE_FIELDS: RecipeFields = {
     [SNOWFLAKE]: {

datahub-web-react/src/app/ingestV2/source/builder/useIngestionSources.ts

@@ -1,8 +1,7 @@
 import { useMemo } from 'react';
 
 import sourcesJson from '@app/ingestV2/source/builder/sources.json';
-
-import { SourceConfig } from './types';
+import { SourceConfig } from '@app/ingestV2/source/builder/types';
 
 export function useIngestionSources() {
     // TODO: replace with call to server once we have access to dynamic list of sources

datahub-web-react/src/app/ingestV2/source/multiStepBuilder/IngestionSourceBottomPanel.tsx

@@ -1,11 +1,14 @@
 import { Button } from '@components';
-import { useCallback, useState } from 'react';
+import React, { useCallback, useState } from 'react';
 
+import {
+    IngestionSourceFormStep,
+    MultiStepSourceBuilderState,
+    SubmitOptions,
+} from '@app/ingestV2/source/multiStepBuilder/types';
 import { MultiStepFormBottomPanel } from '@app/sharedV2/forms/multiStepForm/MultiStepFormBottomPanel';
 import { useMultiStepContext } from '@app/sharedV2/forms/multiStepForm/MultiStepFormContext';
 
-import { IngestionSourceFormStep, MultiStepSourceBuilderState, SubmitOptions } from './types';
-
 export function IngestionSourceBottomPanel() {
     const { isFinalStep, isCurrentStepCompleted, submit } = useMultiStepContext<
         MultiStepSourceBuilderState,
@@ -52,7 +55,7 @@ export function IngestionSourceBottomPanel() {
                 </Button>,
             ];
         },
-        [isFinalStep, isCurrentStepCompleted, onSaveAndRun, isSaveAndRunInProgress],
+        [isFinalStep, isCurrentStepCompleted, onSave, onSaveAndRun, isSaveAndRunInProgress],
     );
 
     return <MultiStepFormBottomPanel renderRightButtons={renderRightButtons} />;