feat(context): Support Viewing and Adding Related Context to All Asset Types #15453

jjoyce0510 · 2025-12-01T05:10:47Z

Summary

This is the final PR for UI for context base V1 feature. Specifically this adds:

You can now view related context docs for an asset beside to it's links (for both V1 and V2 summary tab). This includes a new relatedDocuments field on specific entity types. This looks like a lot of changes but we are just adding this to select entity types. Initially I'd added tot he EntityType base interface but that added it to a bunch of things I really didn't want it for (e.g. execution requests, so I decided to target specific entity types for now). I've also added a new EntityCapabilityType in the entity registry that is used to decide whether to fetch and render related docs.
You can now Move / Delete docs from the document profile itself
You can now link related context docs for an asset from the asset profile!
We've made some changes to how searching documents works so that you see PUBLISHED docs OR your own drafts (owned by you) BY DEFAULT. This will be sufficient for all the features that currently use this GraphQL query.

Loom Overview: https://www.loom.com/share/50dbc526c82746978bd163b9526966c7

jjoyce0510 · 2025-12-01T05:11:20Z

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java

        typeWiring ->
            typeWiring
                .dataFetcher("relationships", new EntityRelationshipsResultResolver(graphClient))
+                .dataFetcher(


REMOVE THIS.

jjoyce0510 · 2025-12-01T05:12:30Z

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java

    builder.type(
        "StructuredPropertyEntity",
-        typeWiring -> typeWiring.dataFetcher("exists", new EntityExistsResolver(entityService)));
+        typeWiring ->


Remove this

codecov · 2025-12-01T05:13:35Z

Codecov Report

❌ Patch coverage is 83.82749% with 60 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...com/linkedin/datahub/graphql/GmsGraphQLEngine.java	0.00%	20 Missing ⚠️
.../resolvers/knowledge/RelatedDocumentsResolver.java	84.37%	7 Missing and 8 partials ⚠️
...-web-react/src/app/document/utils/documentUtils.ts	66.66%	15 Missing ⚠️
...eact/src/app/document/hooks/useRelatedDocuments.ts	83.33%	9 Missing ⚠️
datahub-web-react/src/app/entity/shared/utils.ts	50.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

jjoyce0510 · 2025-12-01T05:14:08Z

.../src/main/java/com/linkedin/datahub/graphql/resolvers/knowledge/SearchDocumentsResolver.java

-   * @param userAndGroupUrns List of URNs for the current user and their groups
-   * @return The combined filter
-   */
-  private Filter buildCombinedFilter(SearchDocumentsInput input, List<String> userAndGroupUrns) {


Mostly removing and making small tweaks to the filtering logic inside of DocumentSearchFilterUtils.java

jjoyce0510 · 2025-12-01T05:14:40Z

.../src/main/java/com/linkedin/datahub/graphql/resolvers/knowledge/SearchDocumentsResolver.java

      criteria.add(
          CriterionUtils.buildCriterion(
              "parentDocument", Condition.EQUAL, input.getParentDocuments()));
-    } else if (input.getParentDocument() != null) {


No one is using this - we are removing this since we just moved to using parentDocuments instead.

...-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/knowledge/DocumentMapper.java

datahub-graphql-core/src/main/resources/connection.graphql

datahub-graphql-core/src/main/resources/auth.graphql

alwaysmeticulous · 2025-12-01T05:15:56Z

✅ Meticulous spotted 0 visual differences across 992 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

_{Expected differences? Click here. Last updated for commit bf16877. This comment will update as new commits are pushed.}

jjoyce0510 · 2025-12-01T05:17:02Z

datahub-graphql-core/src/main/resources/contract.graphql

+  """
+  Get context documents related to this entity
+  """
+  relatedDocuments(input: RelatedDocumentsInput!): RelatedDocumentsResult


Remove this

jjoyce0510 · 2025-12-01T05:18:09Z

datahub-graphql-core/src/main/resources/documents.graphql

+  """
+  Get context documents related to this entity
+  """
+  relatedDocuments(input: RelatedDocumentsInput!): RelatedDocumentsResult


remove this for now..

jjoyce0510 · 2025-12-01T05:18:27Z

datahub-graphql-core/src/main/resources/documents.graphql

  """
-  Optional parent document URN to filter by (for hierarchical browsing)
-  """
-  parentDocument: String


Nothing released here, this is safe to change.

jjoyce0510 · 2025-12-01T05:20:45Z

datahub-graphql-core/src/main/resources/documents.graphql

+  """
+  The starting offset of the result set returned
  """
-  states: [DocumentState!]


Simplifying this interface a lot based on what we actually need.

Remove states filter - now we always default to PUBLISHED OR UNPUBLISHED (with owner == myself).

Remove includeDrafts - this was premature and is not used yet.

Remove filters - this was premature and is not used yet.

searchFlags - this was not used.

jjoyce0510 · 2025-12-01T05:22:51Z

datahub-graphql-core/src/main/resources/entity.graphql

+  """
+  Get context documents related to this entity
+  """
+  relatedDocuments(input: RelatedDocumentsInput!): RelatedDocumentsResult


remove - should NOT be on all types.

jjoyce0510 · 2025-12-01T05:30:46Z

datahub-web-react/src/app/document/hooks/__tests__/useLoadDocumentTree.test.tsx

                input: {
                    query: '*',
                    parentDocuments: urns,
-                    states: [DocumentState.Published, DocumentState.Unpublished],


removing this

jjoyce0510 · 2025-12-01T05:31:41Z

datahub-web-react/src/app/document/hooks/useExtractMentions.ts

@@ -1,39 +1,13 @@
 import { useMemo } from 'react';

+import { extractMentions } from '@app/document/utils/extractMentions';


just refactoring :)

jjoyce0510 · 2025-12-01T05:32:32Z

datahub-web-react/src/app/document/hooks/useLoadDocumentTree.ts

 * - Loading children on demand
 */

-function documentToTreeNode(doc: Document, hasChildren: boolean): DocumentTreeNode {


just refactoring..

codecov · 2025-12-01T05:38:10Z

Bundle Report

Changes will increase total bundle size by 63.2kB (0.22%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
datahub-react-web-esm	28.79MB	63.2kB (0.22%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-*.js`	63.2kB	19.17MB	0.33%

Files in assets/index-*.js:

./src/app/document/hooks/useLoadDocumentTree.ts → Total Size: 3.31kB
./src/app/document/utils/documentUtils.ts → Total Size: 1.11kB
./src/app/document/hooks/useExtractMentions.ts → Total Size: 118 bytes
./src/app/document/hooks/useRelatedDocuments.ts → Total Size: 1.33kB
./src/app/document/hooks/useDocumentTreeMutations.ts → Total Size: 5.44kB
./src/app/entityV2/Entity.tsx → Total Size: 1.92kB
./src/app/entity/shared/utils.ts → Total Size: 5.37kB
./src/app/document/hooks/useSearchDocuments.ts → Total Size: 1.05kB
./src/app/entity/Entity.tsx → Total Size: 2.01kB
./src/app/document/utils/extractMentions.ts → Total Size: 606 bytes

jjoyce0510 · 2025-12-01T05:47:30Z

datahub-web-react/src/app/entityV2/document/summary/DocumentSummaryTab.tsx

+                                />
+                            </Tooltip>
+                        )}
+                        <ActionsMenuWrapper>


This is new!

jjoyce0510 · 2025-12-01T05:50:54Z

datahub-web-react/src/app/entityV2/document/summary/EditableTitle.tsx

    border-radius: 4px;
    resize: none;
-    overflow: hidden;
+    overflow: auto;


Fixing styling for overflowing titles - now we are wrapping.

jjoyce0510 · 2025-12-01T06:00:02Z

datahub-web-react/src/app/entityV2/shared/tabs/Documentation/components/RelatedDocumentItem.tsx

+                            {actor && (
+                                <>
+                                    {' by '}
+                                    {(() => {


Can we simplify this?

jjoyce0510 · 2025-12-01T06:02:42Z

...eb-react/src/app/entityV2/shared/tabs/Documentation/components/AddContextDocumentPopover.tsx

+    );
+
+    /**
+     * Handle creating a new document


From the popover

jjoyce0510 · 2025-12-01T06:20:32Z

datahub-web-react/src/app/homeV2/layout/sidebar/documents/DocumentActionsMenu.tsx

-    const location = useLocation();
    const entityRegistry = useEntityRegistry();

-    const handleDelete = async () => {


simplifying a lot of this. should be no functional changes..

metadata-service/configuration/src/main/resources/application.yaml

jjoyce0510 · 2025-12-01T20:27:35Z

datahub-web-react/src/app/entityV2/shared/tabs/Documentation/components/relatedSectionUtils.ts

+
+import { Document, InstitutionalMemoryMetadata } from '@types';
+
+export type RelatedItem =


Needs unit tests

jjoyce0510 · 2025-12-01T20:27:56Z

datahub-web-react/src/app/homeV2/layout/sidebar/documents/documentDeleteNavigation.ts

+ * Calculates the navigation target after deleting a document.
+ * Returns the URN to navigate to, or null if should go to home.
+ */
+export function calculateDeleteNavigationTarget(


Add unit tests

jjoyce0510 · 2025-12-01T20:28:17Z

datahub-web-react/src/app/document/hooks/useDocumentTreeMutations.ts

    const deleteDocument = useCallback(
        async (urn: string) => {
-            // Get node for rollback
+            // Get node for rollback (may be null if document isn't in tree, e.g., opened in modal)


Need unit test

jjoyce0510 · 2025-12-01T20:28:44Z

datahub-web-react/src/app/document/hooks/useExtractMentions.ts

-    }, [content]);
-
-    return mentions;
+    return useMemo(() => extractMentions(content), [content]);


John Joyce and others added 5 commits November 30, 2025 20:55

Checkpoint

21cd6bf

Addressing chris comments from prev PR

4983e00

delete unnecessary file

7324c1e

Addressing my own comments 1

2487543

resolve more of my own comments

b1dfd1a

github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment smoke_test Contains changes related to smoke tests labels Dec 1, 2025

jjoyce0510 commented Dec 1, 2025

View reviewed changes

datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 1, 2025

jjoyce0510 commented Dec 1, 2025

View reviewed changes

github-actions bot deployed to datahub-wheels (Preview) December 1, 2025 05:13 View deployment

jjoyce0510 commented Dec 1, 2025

View reviewed changes

...-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/knowledge/DocumentMapper.java Show resolved Hide resolved

github-actions bot deployed to datahub-project-web-react (Preview) December 1, 2025 05:15 View deployment

jjoyce0510 commented Dec 1, 2025

View reviewed changes

datahub-graphql-core/src/main/resources/connection.graphql Outdated Show resolved Hide resolved

jjoyce0510 commented Dec 1, 2025

View reviewed changes

datahub-graphql-core/src/main/resources/auth.graphql Outdated Show resolved Hide resolved

jjoyce0510 commented Dec 1, 2025

View reviewed changes

vercel bot deployed to Preview December 1, 2025 05:22 View deployment

jjoyce0510 commented Dec 1, 2025

View reviewed changes

metadata-service/configuration/src/main/resources/application.yaml Outdated Show resolved Hide resolved

Adding finishing touches

9172129

github-actions bot deployed to datahub-wheels (Preview) December 1, 2025 07:30 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) December 1, 2025 07:32 View deployment

More linting fixes

15b6c85

github-actions bot deployed to datahub-wheels (Preview) December 1, 2025 07:38 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) December 1, 2025 07:40 View deployment

Adding fixes to documents

980b361

github-actions bot deployed to datahub-wheels (Preview) December 1, 2025 07:44 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) December 1, 2025 07:46 View deployment

vercel bot deployed to Preview December 1, 2025 08:00 View deployment

jjoyce0510 commented Dec 1, 2025

View reviewed changes

John Joyce added 2 commits December 1, 2025 12:29

Fix cypress tests

05e88e9

Fixing draft test

8c9c132

github-actions bot deployed to datahub-wheels (Preview) December 2, 2025 23:38 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) December 2, 2025 23:41 View deployment

vercel bot deployed to Preview December 2, 2025 23:55 View deployment

John Joyce added 2 commits December 3, 2025 10:06

Attempt to fix test

ad44436

attempt unit test updates

bf16877

github-actions bot deployed to datahub-wheels (Preview) December 4, 2025 08:38 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) December 4, 2025 08:41 View deployment

vercel bot deployed to Preview December 4, 2025 08:54 View deployment

		@@ -1,39 +1,13 @@
		import { useMemo } from 'react';

		import { extractMentions } from '@app/document/utils/extractMentions';


		import { Document, InstitutionalMemoryMetadata } from '@types';

		export type RelatedItem =

feat(context): Support Viewing and Adding Related Context to All Asset Types #15453

Are you sure you want to change the base?

feat(context): Support Viewing and Adding Related Context to All Asset Types #15453

Uh oh!

Conversation

jjoyce0510 commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alwaysmeticulous bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jjoyce0510 commented Dec 1, 2025 •

edited

Loading

codecov bot commented Dec 1, 2025 •

edited

Loading

alwaysmeticulous bot commented Dec 1, 2025 •

edited

Loading

codecov bot commented Dec 1, 2025 •

edited

Loading