Broken with TiddlyWiki 5.1.19

[andrewgoz]

When I click save I get an immediate "Internal JavaScript Error, The data is invalid." The "Save As" dialog is not shown.

Call stack shows:
Error
at TiddlyIESaver.prototype.save (eval code:40:3)
at SaverHandler.prototype.saveWiki (eval code:175:3)
at Anonymous function (eval code:91:4)
at eventListeners[type] (eval code:399:4)
at Widget.prototype.dispatchEvent (eval code:412:3)
at Widget.prototype.dispatchEvent (eval code:418:3)
at Widget.prototype.dispatchEvent (eval code:418:3)
at Widget.prototype.dispatchEvent (eval code:418:3)
at Widget.prototype.dispatchEvent (eval code:418:3)
at Widget.prototype.dispatchEvent (eval code:418:3)"

Line 40 looks like "window.TiddlyIE.save(pathname, text);"

So far I've worked out that TiddlyIE is looking for an MOTW that has "http://tiddlywiki.com/" in it; the new TiddlyWiki has changed the http to https.

However, I've changed the 5.1.19 MOTW to be "http" and I'm still getting the same problem.

I think TiddlyIE should:

1. Accept an MOTW with either http or https
2. The MOTW should not need to end with '\r' (remove existing trailing '\r')
3. The tokenizer should split on both '\r' and '\n' (line 187: L"\r\n")

[davidjade]

I haven't investigated this but I wanted to call out that it is/was IE that needed the \r to follow the MOTW - that's the reason for the \r check. If it's not formatted in the correct way that IE expects, IE simply and silently rejects it and the IE BHO won't work as the scripts that call the BHO won't run correctly in that case.

It is also not clear to me whether IE would accept a MOTW with a HTTPS in there either (but it might - I honestly don't remember anymore).

This is what I remember - IE is can be very finky in regards to the MOTW formatting. I suspect that if the new TiddleWiki save isn't invoking the IE BHO helper, it is most likely because IE doesn't like something in the wiki document.

[andrewgoz]

Hi David, Thanks for your email. I've installed Visual Studio and am having a poke at this when I have the time. I'll comment further when (if) I discover anything. Cheers, Andrew

…

On Wed, 10 Apr 2019 at 02:30, David Jade ***@***.***> wrote: I haven't investigated this but I wanted to call out that it is/was IE that needed the \r to follow the MOTW - that's the reason for the \r check. If it's not formatted in the correct way that IE expects, IE simply and silently rejects it and the IE BHO won't work as the scripts that call the BHO won't run correctly in that case. It is also not clear to me whether IE would accept a MOTW with a HTTPS in there either (but it might - I honestly don't remember anymore). This is what I remember - IE is can be very finky in regards to the MOTW formatting. I suspect that if the new TiddleWiki save isn't invoking the IE BHO helper, it is most likely because IE doesn't like something in the wiki document. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACKOhswB9Hez7rSfUxM5aiXmhcVuWHDmks5vfNxEgaJpZM4cjvlj> .

-- Andrew