You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Transport version upper bounds are currently set to their values from
upstream main whenever no new definition is detected. However, this
is like a partial merge of upstream, and produces broken state files.
This commit temporarily comments out resetting until a more robust
solution is built.
Copy file name to clipboardExpand all lines: build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/transport/TransportVersionGenerationFuncTest.groovy
+10-2Lines changed: 10 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -90,6 +90,9 @@ class TransportVersionGenerationFuncTest extends AbstractTransportVersionFuncTes
90
90
assertUpperBound("9.2", "new_tv,8124000")
91
91
}
92
92
93
+
/*
94
+
temporarily muted, see https://github.com/elastic/elasticsearch/pull/135226
95
+
93
96
def "invalid changes to a upper bounds should be reverted"() {
Copy file name to clipboardExpand all lines: build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/transport/GenerateTransportVersionDefinitionTask.java
+2-1Lines changed: 2 additions & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -107,7 +107,8 @@ public void run() throws IOException {
107
107
108
108
getLogger().lifecycle("Generating transport version name: " + targetDefinitionName);
109
109
if (targetDefinitionName.isEmpty()) {
110
-
resetAllUpperBounds(resources);
110
+
// TODO: resetting upper bounds needs to be done locally, otherwise it pulls in some (incomplete) changes from upstream main
0 commit comments