Add option to disable right-click menu bar overlay (PR jordanbaird#893)

Adapted from upstream PR jordanbaird#893 by rafaelreverberi.
- Disabling 'Enable secondary context menu' suppresses Ice right-click menus
- Adds Option+Command+click fallback to open Ice settings when disabled
- Improves compatibility with apps like DynamicLake
- Applied to HIDEventManager.swift and updated settings API for macos-26

Author: davidrudduck

Ice/Events/HIDEventManager.swift

@@ -48,6 +48,9 @@ final class HIDEventManager: ObservableObject {
         guard let self, isEnabled, let appState, let screen = bestScreen(appState: appState) else {
             return event
         }
+        if handleOpenSettingsFallback(with: event, appState: appState, screen: screen) {
+            return event
+        }
         switch event.type {
         case .leftMouseDown:
             handleShowOnClick(appState: appState, screen: screen)
@@ -405,6 +408,26 @@ extension HIDEventManager {
         }
     }
 
+    // MARK: Handle Open Settings Fallback
+
+    /// When secondary context menus are disabled, ⌥⌘-click in the menu bar opens Ice settings.
+    @discardableResult
+    private func handleOpenSettingsFallback(with event: NSEvent, appState: AppState, screen: NSScreen) -> Bool {
+        guard
+            !appState.settings.advanced.enableSecondaryContextMenu,
+            event.type == .leftMouseDown || event.type == .rightMouseDown,
+            isMouseInsideMenuBar(appState: appState, screen: screen)
+        else {
+            return false
+        }
+        let modifiers = event.modifierFlags.intersection(.deviceIndependentFlagsMask)
+        guard modifiers.contains([.option, .command]) else {
+            return false
+        }
+        appState.appDelegate?.openSettingsWindow()
+        return true
+    }
+
     // MARK: Handle Prevent Show On Hover
 
     private func handlePreventShowOnHover(with event: NSEvent, appState: AppState, screen: NSScreen) {

Ice/MenuBar/ControlItem/ControlItem.swift

@@ -459,14 +459,16 @@ final class ControlItem {
             return
         }
 
+        let enableSecondaryContextMenu = appState?.settings.advanced.enableSecondaryContextMenu ?? true
+
         switch event.type {
         case .leftMouseDown:
             let modifierFlags = NSEvent.modifierFlags
 
             // Running this from a Task seems to improve the visual
             // responsiveness of the status item's button.
             Task {
-                if modifierFlags == .control {
+                if modifierFlags == .control, enableSecondaryContextMenu {
                     showMenu()
                     return
                 }
@@ -488,6 +490,9 @@ final class ControlItem {
                 }
             }
         case .rightMouseUp:
+            guard enableSecondaryContextMenu else {
+                return
+            }
             showMenu()
         default:
             return

Ice/Settings/SettingsPanes/AdvancedSettingsPane.swift

@@ -96,7 +96,8 @@ struct AdvancedSettingsPane: View {
                 """
                 Right-click in an empty area of the menu bar to display a minimal \
                 version of Ice's menu. Disable this setting if you encounter conflicts \
-                with other apps.
+                with other apps like DynamicLake. When disabled, \
+                Option + Command + click in the menu bar opens Ice settings.
                 """
             )
             .padding(.trailing, 75)