refacto: resolve memory shenanigan

Author: Dawoox

src/commands/dir.c

@@ -16,16 +16,19 @@
 
 static bool is_path_allowed(char const *home, char const *newpath)
 {
-    char const *real_newpath = realpath(newpath, NULL);
+    char real_newpath[PATH_MAX];
 
-    if (real_newpath == NULL)
+    if (realpath(newpath, real_newpath) == NULL)
         return false;
     return strncmp(home, real_newpath, strlen(home)) == 0;
 }
 
 void cmd_pwd_handler(client_t *client, __attribute__((unused)) const char *_)
 {
-    write_msg(client, "257", "%s", realpath(client->currPath, NULL));
+    char path_buff[PATH_MAX];
+
+    realpath(client->currPath, path_buff);
+    write_msg(client, "257", "%s", path_buff);
 }
 
 void cmd_cdup_handler(client_t *client, __attribute__((unused)) const char *_)
@@ -48,19 +51,18 @@ static int check_for_path_errors(const char *args, const char *realpath_buff,
 void cmd_cwd_handler(client_t *client, const char *args)
 {
     char new_path[PATH_MAX] = {0};
-    char *realpath_buff;
+    char realpath_buff[PATH_MAX] = {0};
 
     if (args[0] == '/') {
-        realpath_buff = realpath(args, NULL);
+        realpath(args, realpath_buff);
     } else {
         strcpy(new_path, client->currPath);
         strcat(new_path, "/");
         strcat(new_path, args);
-        realpath_buff = realpath(new_path, NULL);
+        realpath(new_path, realpath_buff);
         if (check_for_path_errors(args, realpath_buff, client) == -1)
             return;
     }
     strcpy(client->currPath, realpath_buff);
-    free(realpath_buff);
     write_msg(client, "250", "Requested file action okay, completed.");
 }

src/commands/files.c

@@ -151,11 +151,10 @@ static void compute_dele_path(char *path_buffer, const char *given_path,
 void cmd_dele_handler(client_t *client, const char *args)
 {
     char path_buff[BUFSIZ] = {0};
-    char *dele_path;
+    char delete_path[BUFSIZ];
 
     compute_dele_path(path_buff, args, client);
-    dele_path = realpath(path_buff, NULL);
-    if (!is_path_allowed(client->home, dele_path)) {
+    if (!is_path_allowed(client->home, realpath(path_buff, delete_path))) {
         write_msg(client, "550", "Requested action not taken.");
         return;
     }
@@ -165,5 +164,4 @@ void cmd_dele_handler(client_t *client, const char *args)
         write_msg(client, "250",
             "250 Requested file action okay, completed.");
     }
-    free(dele_path);
 }

src/myftp.c

@@ -33,7 +33,7 @@ static int print_help(void)
 
 int main(const int argc, const char *argv[])
 {
-    server_t server = {0};
+    static server_t server = {0};
 
     setenv("LC_ALL", "C", 1);
     if (argc != 3)

src/server.c

@@ -47,8 +47,7 @@ static void searching_new_clients(server_t *server)
     client->control_fd = accept(server->server_fd,
         (struct sockaddr*) &client_addr, &client_len);
     init_client(client, server);
-    strcpy(client->currPath, realpath(server->anonymous_default_path,
-        NULL));
+    realpath(server->anonymous_default_path, client->currPath);
     printf("[INFO] New client connection\n");
     write_welcome(client);
 }
@@ -119,15 +118,13 @@ void events_loop(server_t *server)
 
 static int load_anon_home(server_t *server)
 {
-    char *homepath;
+    char homepath_buff[PATH_MAX];
 
-    homepath = realpath(server->anonymous_default_path, NULL);
-    if (homepath == NULL) {
+    if (realpath(server->anonymous_default_path, homepath_buff) == NULL) {
         fprintf(stderr, "myftp: invalid anonymous home path\n");
         return -1;
     }
-    strcpy(server->anonymous_default_path, homepath);
-    free(homepath);
+    strcpy(server->anonymous_default_path, homepath_buff);
     printf("[INFO] Account 'Anonymous' home is: %s\n",
         server->anonymous_default_path);
     return 0;