fix: coding style compliance

Author: Dawoox

Makefile

@@ -15,7 +15,7 @@ CFLAGS	+=	-Wshadow
 CFLAGS	+=	-Wunreachable-code
 CFLAGS	+=	-Wmissing-prototypes
 CFLAGS	+=	-pedantic
-CFLAGS	+=	-I./include/ -g3 -O0
+CFLAGS	+=	-I./include/
 BDIR	=	.build
 
 NAME	=	myftp

include/network.h

@@ -13,7 +13,8 @@
 void write_msg(const client_t *client, const char *code, const char *fmt,
     ...);
 void write_templated_msg(const client_t *client, const char *template);
-
+void parse_client_input(client_t *client);
+void process_client(client_t *client);
 
 void close_data_sock(client_t *client);
 int accept_data_sock(client_t *client);

include/server.h

@@ -55,6 +55,8 @@ typedef struct {
 } command_t;
 
 int init_server(server_t *server);
+bool client_cmd_handler(const command_t *command, const char *buffer,
+    client_t *client);
 void write_msg_to_client(int client_control_fd, const char *str);
 void events_loop(server_t *server);
 

src/network/input_buffer.c

@@ -0,0 +1,58 @@
+/*
+** EPITECH PROJECT, 2025
+** myftp
+** File description:
+** input_buffer.c
+*/
+
+#include <stdio.h>
+#include <string.h>
+
+#include "network.h"
+
+static void parse_client_buffer(client_t *client, char *buff_not_read)
+{
+    const size_t buff_len = strlen(client->cmd_buffer);
+    size_t idx = 0;
+
+    for (; idx < buff_len; idx++) {
+        if (client->cmd_buffer[idx] == '\r' && idx + 1 < buff_len
+            && client->cmd_buffer[idx + 1] == '\n') {
+            idx += 2;
+            strncpy(client->cmd, client->cmd_buffer, idx - 1);
+            client->cmd[idx - 1] = '\0';
+            client->cmd[idx - 2] = '\0';
+            client->should_be_processed = true;
+            break;
+            }
+    }
+    if (idx < buff_len)
+        strcat(buff_not_read, &client->cmd_buffer[idx]);
+    if (!client->should_be_processed)
+        strcat(buff_not_read, client->cmd_buffer);
+}
+
+void parse_client_input(client_t *client)
+{
+    char buff_not_read[BUFSIZ] = {0};
+
+    memset(client->cmd, 0, BUFSIZ);
+    parse_client_buffer(client, buff_not_read);
+    memset(client->cmd_buffer, 0, BUFSIZ);
+    strcpy(client->cmd_buffer, buff_not_read);
+    client->cmd_buffer_offset = strlen(buff_not_read);
+}
+
+void process_client(client_t *client)
+{
+    bool cmd_found = false;
+
+    for (size_t i = 0; i < COMMANDS_SIZE && !cmd_found; i++)
+        if (client_cmd_handler(&COMMANDS[i], client->cmd, client) == true) {
+            cmd_found = true;
+        }
+    if (!cmd_found)
+        write_msg_to_client(client->control_fd, "500 Syntax Error");
+    client->should_be_processed = false;
+    parse_client_input(client);
+}

src/server.c

@@ -57,7 +57,7 @@ static void searching_new_clients(server_t *server)
     }
 }
 
-static bool client_cmd_handler(const command_t *command, const char *buffer,
+bool client_cmd_handler(const command_t *command, const char *buffer,
     client_t *client)
 {
     if (strncasecmp(command->name, buffer, strlen(command->name)) != 0)
@@ -74,60 +74,15 @@ static bool client_cmd_handler(const command_t *command, const char *buffer,
     return true;
 }
 
-static void parse_client_buffer(client_t *client, char *buff_not_read)
-{
-
-    const size_t buff_len = strlen(client->cmd_buffer);
-    size_t idx = 0;
-
-    for (; idx < buff_len; idx++) {
-        if (client->cmd_buffer[idx] == '\r' && idx + 1 < buff_len && client->cmd_buffer[idx + 1] == '\n') {
-            idx += 2;
-            strncpy(client->cmd, client->cmd_buffer, idx - 1);
-            client->cmd[idx - 1] = '\0';
-            client->cmd[idx - 2] = '\0';
-            client->should_be_processed = true;
-            break;
-        }
-    }
-    if (idx < buff_len)
-        strcat(buff_not_read, &client->cmd_buffer[idx]);
-    if (!client->should_be_processed)
-        strcat(buff_not_read, client->cmd_buffer);
-}
-
-static void parse_client_input(client_t *client)
-{
-    char buff_not_read[BUFSIZ] = {0};
-
-    client->should_be_processed = false;
-    memset(client->cmd, 0, BUFSIZ);
-    parse_client_buffer(client, buff_not_read);
-    memset(client->cmd_buffer, 0, BUFSIZ);
-    strcpy(client->cmd_buffer, buff_not_read);
-    client->cmd_buffer_offset = strlen(buff_not_read);
-    //printf("[INFO] Current command: %s\n", client->cmd);
-    //printf("[INFO] Command buffer: %s\n", client->cmd_buffer);
-}
-
 static void reply_client(client_t *client)
 {
-    bool cmd_found = false;
-
-    //printf("Writing in buffer with offset of: %lu\n", client->cmd_buffer_offset);
     if (read(client->control_fd, client->cmd_buffer +
         client->cmd_buffer_offset, BUFSIZ - client->cmd_buffer_offset) < 1)
         return;
-    printf("[ <- ] '%s'\n", client->cmd_buffer);
+    printf("[ <- ] %s", client->cmd_buffer);
     parse_client_input(client);
-    while (client->should_be_processed) {
-        for (size_t i = 0; i < COMMANDS_SIZE && !cmd_found; i++)
-            if (client_cmd_handler(&COMMANDS[i], client->cmd, client) == true)
-                cmd_found = true;
-        if (!cmd_found)
-            write_msg_to_client(client->control_fd, "500 Syntax Error");
-        parse_client_input(client);
-    }
+    while (client->should_be_processed)
+        process_client(client);
 }
 
 void events_loop(server_t *server)