src/goDebugFactory: add --check-go-version=false

If go-delve/delve#2684 is in,
users who use go versions outside delve's officially
supported version range, will have visible warnings.
Otherwise, we will need to have our own custom version
check and make the warning visible.

Fixes golang#1716

Change-Id: Ide76978b038f4efecdf3485abdcae37323855af5
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/347562
Trust: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Suzy Mueller <[email protected]>

Author: hyangah

src/goDebugFactory.ts

@@ -367,8 +367,11 @@ function spawnDlvDapServerProcess(
 
 	const dlvArgs = new Array<string>();
 	dlvArgs.push('dap');
-	// add user-specified dlv flags first. When duplicate flags are specified,
+	// When duplicate flags are specified,
 	// dlv doesn't mind but accepts the last flag value.
+	// Add user-specified dlv flags first except
+	//  --check-go-version that we want to disable by default but allow users to override.
+	dlvArgs.push('--check-go-version=false');
 	if (launchAttachArgs.dlvFlags && launchAttachArgs.dlvFlags.length > 0) {
 		dlvArgs.push(...launchAttachArgs.dlvFlags);
 	}