Skip to content

Commit e08e111

Browse files
authored
fix(chips & tags): missing default:light variant (#691)
* feat: added default:light variant * refactor: chips and tags are supposed to get a font-weight of 500 instead of the default 400
1 parent 3994704 commit e08e111

File tree

4 files changed

+22
-1
lines changed

4 files changed

+22
-1
lines changed

source/_patterns/01-elements/chips/chip.scss

+7
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
border: solid 1px $db-color-cool-gray-400;
77
border-radius: $chip---radius;
88
display: inline-flex;
9+
font-weight: 500;
910

1011
// Link related styles
1112
font-size: to-rem($pxValue: 14);
@@ -42,6 +43,12 @@
4243
color: $chip-checked--color;
4344

4445
//*** Variants ***
46+
&[data-variant="light"] {
47+
background-color: $db-color-cool-gray-200;
48+
color: $db-color-cool-gray-700;
49+
border: 1px solid $db-color-cool-gray-400;
50+
}
51+
4552
&[data-variant="warning"] {
4653
background-color: $db-color-warning;
4754
}

source/_patterns/01-elements/chips/chips.json

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
{
22
"variants": [
3+
{
4+
"label": "Light",
5+
"variant": "light"
6+
},
37
{
48
"label": "Warning",
59
"variant": "warning"

source/_patterns/01-elements/tags/tag.scss

+7-1
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
border-radius: $tag---radius;
77
color: $tag---color;
88
display: inline-flex;
9+
font-weight: 500;
910

1011
// Link related styles
1112
font-size: to-rem($pxValue: 12);
12-
font-weight: initial;
1313
height: to-rem($pxValue: 24);
1414
justify-content: center;
1515
padding-left: to-rem($pxValue: 4);
@@ -27,6 +27,12 @@
2727
}
2828

2929
//*** Variants ***
30+
&[data-variant="light"] {
31+
background-color: $db-color-cool-gray-200;
32+
color: $db-color-cool-gray-700;
33+
border: 1px solid $db-color-cool-gray-400;
34+
}
35+
3036
&[data-variant="warning"] {
3137
background-color: $db-color-warning-small-font;
3238
}

source/_patterns/01-elements/tags/tags.json

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
{
22
"variants": [
3+
{
4+
"label": "Light",
5+
"variant": "light"
6+
},
37
{
48
"label": "Informative",
59
"variant": "informative"

0 commit comments

Comments
 (0)