Skip to content

Commit 47a7499

Browse files
mfranzkenmerget
andauthored
fix: adapting Nicos solution regarding Angular consumption (#572)
* fix: adapting Nicos solution regarding Angular consumption * refactor: added relevant entry and renamed accordingly to the correct filetype * chore: removed obsolete section * chore: removed obsolete section Co-authored-by: Nicolas Merget <[email protected]>
1 parent a6d3a94 commit 47a7499

File tree

8 files changed

+56
-75
lines changed

8 files changed

+56
-75
lines changed

README.md

-17
Original file line numberDiff line numberDiff line change
@@ -61,23 +61,6 @@ If you miss a component than [contribute](CONTRIBUTING.md), please.
6161
* [DB UI Elements with Angular](showcase/angular-showcase/README.md)
6262
* [DB UI Elements with Vue](showcase/vue-showcase/README.md)
6363

64-
## FAQ
65-
66-
###
67-
68-
- I'm facing problems like the following when using `@db-ui/ngx-elements` with Angular version 14:
69-
```
70-
Interface 'HTMLDbBreadcrumbElement' cannot simultaneously extend types 'DbBreadcrumb' and 'HTMLStencilElement'.
71-
Named property 'ariaLabel' of types 'DbBreadcrumb' and 'HTMLStencilElement' are not identical
72-
```
73-
74-
![Bildschirmfoto 2022-09-15 um 10 31 21](https://user-images.githubusercontent.com/2963522/190355655-429251e6-0048-4c66-aebc-c6e45268768f.png)
75-
76-
The solution is to set the following option within the `CompileOptions` section within your `TsConfig`, until we provide a central solution:
77-
```JSON
78-
"skipLibCheck": true
79-
```
80-
8164
## Deutsche Bahn brand
8265

8366
As we'd like to perfectly support our users and customers on their digital journey, the usage of Deutsche Bahn brand and trademarks are bound to clear guidelines and restrictions even when being used with the code that we're providing with this product.

doc/migrationGuide.adoc

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
= Migration Guides
2+
3+
As with every release you're recommended to do a visual regression testing for your application.
4+
5+
Especially the following aspects have changed through the various different releases and would need your review and probably adaptions within your code base.
6+
7+
== DB UI Core 0.17.0 Migration Guide
8+
9+
=== db-breadcrumb
10+
11+
**BREAKING CHANGE**: We needed to change the Breadcrumbs `aria-label` attribute to `arialabel` for compatibility reasons.

doc/migrationGuide.html

-1
This file was deleted.

packages/db-ui-elements-angular/README.md

-17
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,6 @@
55
[![Conventional Commits](https://img.shields.io/badge/Conventional%20Commits-1.0.0-yellow.svg)](https://conventionalcommits.org)
66
[![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat-square)](https://makeapullrequest.com)
77

8-
## FAQ
9-
10-
###
11-
12-
- I'm facing problems like the following when using `@db-ui/ngx-elements` with Angular version 14:
13-
```
14-
Interface 'HTMLDbBreadcrumbElement' cannot simultaneously extend types 'DbBreadcrumb' and 'HTMLStencilElement'.
15-
Named property 'ariaLabel' of types 'DbBreadcrumb' and 'HTMLStencilElement' are not identical
16-
```
17-
18-
![Bildschirmfoto 2022-09-15 um 10 31 21](https://user-images.githubusercontent.com/2963522/190355655-429251e6-0048-4c66-aebc-c6e45268768f.png)
19-
20-
The solution is to set the following option within the `CompileOptions` section within your `TsConfig`, until we provide a central solution:
21-
```JSON
22-
"skipLibCheck": true
23-
```
24-
258
## Deutsche Bahn brand
269

2710
As we'd like to perfectly support our users and customers on their digital journey, the usage of Deutsche Bahn brand and trademarks are bound of clear guidelines and restrictions even when being used with the code that we're provide with this product; Deutsche Bahn fully reserves all rights regarding the Deutsche Bahn brand, even though that we're providing the code of DB UI products free to use and release it under the Apache 2.0 license.

packages/db-ui-elements-stencil/src/components/db-breadcrumb/__tests__/db-breadcrumb.spec.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@ describe('db-breadcrumb', () => {
2121
const page = await newSpecPage({
2222
components: [DbBreadcrumb],
2323
html: `
24-
<db-breadcrumb aria-label='Aria-Breadcrumb'>
24+
<db-breadcrumb arialabel='Aria-Breadcrumb'>
2525
<db-link href='http://db.test/link1'>Link 1</db-link>
2626
<db-link href='//db.test/link2'>Link 2</db-link>
2727
<db-link href='#link3' aria-current='location'>Link 3</db-link>
2828
</db-breadcrumb>
2929
`
3030
});
3131
expect(page.root).toEqualHtml(`
32-
<db-breadcrumb aria-label='Aria-Breadcrumb' >
32+
<db-breadcrumb arialabel='Aria-Breadcrumb' >
3333
<nav class='cmp-breadcrumb' aria-label='Aria-Breadcrumb'>
3434
<ol>
3535
<li><db-link href='http://db.test/link1'>Link 1</db-link></li>

packages/db-ui-elements-stencil/src/components/db-breadcrumb/db-breadcrumb.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export class DbBreadcrumb {
2424
/**
2525
* an optional [`aria-label`-attribute](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-label)
2626
*/
27-
@Prop({ reflect: true, attribute: 'aria-label' }) ariaLabel: string;
27+
@Prop({ reflect: true }) arialabel: string;
2828
private compData: DbLinkType[];
2929

3030
private hasItemsWrapper: boolean;
@@ -55,7 +55,7 @@ export class DbBreadcrumb {
5555

5656
render() {
5757
return (
58-
<nav class="cmp-breadcrumb" aria-label={this.ariaLabel}>
58+
<nav class="cmp-breadcrumb" aria-label={this.arialabel}>
5959
{this.compData && <ol innerHTML={getCompDataHtml(this.compData)} />}
6060
{!this.compData && (
6161
<ol>

packages/db-ui-elements-stencil/src/components/db-breadcrumb/readme.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77

88
## Properties
99

10-
| Property | Attribute | Description | Type | Default |
11-
| ----------- | ------------ | --------------------------------------------------------------------------------------------------------------------------- | -------- | ----------- |
12-
| `ariaLabel` | `aria-label` | an optional [`aria-label`-attribute](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-label) | `string` | `undefined` |
13-
| `data` | `data` | The data attribute can be used to generate breadcrumb by data. | `string` | `undefined` |
10+
| Property | Attribute | Description | Type | Default |
11+
| ----------- | ----------- | --------------------------------------------------------------------------------------------------------------------------- | -------- | ----------- |
12+
| `arialabel` | `arialabel` | an optional [`aria-label`-attribute](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-label) | `string` | `undefined` |
13+
| `data` | `data` | The data attribute can be used to generate breadcrumb by data. | `string` | `undefined` |
1414

1515

1616
----------------------------------------------

showcase/angular-showcase/package-lock.json

+37-32
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)