Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(textarea): scope overflow declaration #3670

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(textarea): scope overflow declaration #3670

wants to merge 2 commits into from

Conversation

mfranzke
Copy link
Member

Proposed changes

Resolves #3669

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🐛bug Something isn't working label Jan 14, 2025
@mfranzke mfranzke self-assigned this Jan 14, 2025
@mfranzke mfranzke linked an issue Jan 14, 2025 that may be closed by this pull request
v3 textarea readonly + disabled: border is cut off #3669
Open
7 tasks
@mfranzke mfranzke enabled auto-merge (squash) January 14, 2025 08:17
@mfranzke mfranzke removed their assignment Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/3669-v3-textarea-readonly-+-disabled-border-is-cut-off

@github-actions github-actions bot added the 🏘components Changes inside components folder label Jan 14, 2025
@nmerget
Copy link
Member

nmerget commented Jan 14, 2025

https://css-tip.com/overflow-detection/ <- we could check out this as well, but it is nice to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget left review comments

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🐛bug Something isn't working 🏘components Changes inside components folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v3 textarea readonly + disabled: border is cut off
2 participants
@mfranzke @nmerget