Skip to content

Commit b5f1efc

Browse files
Improve metric 'equality' check when searching
1 parent c35aa8f commit b5f1efc

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

dbt_semantic_interfaces/transformations/measure_to_metric_transformation_pieces/measure_features_to_metric_name.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,12 @@ def _find_metric_clone_in_manifest(
7070
# this allows us to a straight equality comparison, which is safer in the future
7171
# than implementing a custom comparison function.
7272
search_metric.name = existing_metric.name
73+
search_metric.description = existing_metric.description
74+
search_metric.label = existing_metric.label
7375
search_metric.metadata = existing_metric.metadata
7476
search_metric.type_params.is_private = existing_metric.type_params.is_private
77+
search_metric.config = existing_metric.config
78+
7579
if search_metric == existing_metric:
7680
return existing_metric
7781
print("provided metric", search_metric)

0 commit comments

Comments
 (0)