Add measures to metrics (temporary) & fix metric deduplication #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
4 tasks
theyostalservice
force-pushed
the
patricky/add_measure_to_new_metrics_01
branch
from
6fc1365 to
b5f1efc
Compare
theyostalservice
force-pushed
the
patricky/add_measure_to_new_metrics_01
branch
from
b5f1efc to
e35ed6e
Compare
theyostalservice
commented
Oct 2, 2025
| type_params: | ||
| measure: | ||
| name: bookings | ||
| fill_nulls_with: 15 |
Contributor
Author
There was a problem hiding this comment.
de-duplicating cut the number of metrics down by 1, but I wanted to make sure we had variety in our tests so I made this one require a new metric.
Contributor
There was a problem hiding this comment.
what a silly metric!
theyostalservice
changed the title
theyostalservice
commented
Oct 2, 2025
...s/transformations/measure_to_metric_transformation_pieces/measure_features_to_metric_name.py
Show resolved
Hide resolved
...s/transformations/measure_to_metric_transformation_pieces/measure_features_to_metric_name.py
Outdated
Show resolved
Hide resolved
Contributor
courtneyholcomb
left a comment
courtneyholcomb
left a comment
There was a problem hiding this comment.
One main concern!
...s/transformations/measure_to_metric_transformation_pieces/measure_features_to_metric_name.py
Outdated
Show resolved
Hide resolved
...s/transformations/measure_to_metric_transformation_pieces/measure_features_to_metric_name.py
Outdated
Show resolved
Hide resolved
...s/transformations/measure_to_metric_transformation_pieces/measure_features_to_metric_name.py
Outdated
Show resolved
Hide resolved
| type_params: | ||
| measure: | ||
| name: bookings | ||
| fill_nulls_with: 15 |
Contributor
There was a problem hiding this comment.
what a silly metric!
Contributor
Author
Merge activity
|
theyostalservice
added a commit
to dbt-labs/metricflow
that referenced
this pull request
Oct 3, 2025
Version BUUUUUUUMP This PR is just here to pull in the new transformations and such from dsi. Early commits in this PR will be pinned to commits while I'm working on feeding dbt-labs/dbt-semantic-interfaces#436 to the merge-asaurus. Snapshot updates reflect the fact that now(*) we produce more metrics to replace measures, reflecting the changes in structure for the new user YAML. (*) "now" is true, but ONLY IN TESTS. Because of a transformation rule that exists only in MF right now, we don't use the list of transformations directly from dsi. See upstack #1877 for the PR that brings these changes to prod. OTH, tests DO run on the default list of metric transformations from dsi, so the snapshots needed more immediate updating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #387
Description
This PR contains a few small changes and improvements, all grouped up in the process of getting to a point where metricflow can onboard onto the new dsi version immediately.
At a high level, these changes take three forms. I've tried to detail in comments throughout the PR, but here as well:
measures and sometimesinput_measuresto some of the new metrics made in transformations. This is only necessary because the upgrades in MF are not yet complete and some operations still throw errors when encountering metrics without input measures (especially in tests :/ ), and these new lines can be removed in a few weeks when everything is ready.I've also tested this by pointing the metricflow repo at the top commit here to make sure
make testis running alright since the latest dsi version would not work in MF before.Checklist
changie newto create a changelog entry