Skip to content

Commit 6796011

Browse files
committed
- Multithreading fix
- Include bash so the startup script works in alpine.
1 parent 8e0443f commit 6796011

5 files changed

Lines changed: 13 additions & 6 deletions

File tree

Dockerfile

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,14 @@ MAINTAINER Matt Conroy <elduderino@mailinator.com>
44
# Install java 8
55
RUN apk add --no-cache openjdk8
66

7+
# Install bash so that the server can actually run.
8+
RUN apk add --no-cache bash
9+
710
# Add forklift server
811
WORKDIR /tmp
9-
ADD server/target/universal/forklift-server-0.24.zip forklift.zip
12+
ADD server/target/universal/forklift-server-0.25.zip forklift.zip
1013
RUN yes | unzip -d /usr/local forklift.zip
11-
RUN ln -s /usr/local/forklift-server-0.24 /usr/local/forklift
14+
RUN ln -s /usr/local/forklift-server-0.25 /usr/local/forklift
1215
RUN rm forklift.zip
1316
RUN mkdir -p /usr/local/forklift/consumers
1417

README.adoc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ full documentation.
99
link:doc/forklift.adoc[Documentation]
1010

1111
== Releases
12+
* 0.25
13+
** Fix multithreading that didn't scale past two threads.
14+
** Include bash in the alpine based docker container so work arounds aren't necessary to start the system.
15+
1216
* 0.24
1317
** Synchronous producers
1418

core/build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ organization := "com.github.dcshock"
22

33
name := "forklift"
44

5-
version := "0.18"
5+
version := "0.19"
66

77
// target and Xlint cause sbt dist to fail
88
javacOptions ++= Seq("-source", "1.8")//, "-target", "1.8", "-Xlint")

core/src/main/java/forklift/consumer/Consumer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ else if (queue != null)
190190
log.info("Creating thread pool of {}", multiThreaded.value());
191191
blockQueue = new ArrayBlockingQueue<Runnable>(multiThreaded.value() * 100 + 100);
192192
threadPool = new ThreadPoolExecutor(
193-
Math.min(2, multiThreaded.value()), multiThreaded.value(), 5L, TimeUnit.MINUTES, blockQueue);
193+
multiThreaded.value(), multiThreaded.value(), 5L, TimeUnit.MINUTES, blockQueue);
194194
threadPool.setRejectedExecutionHandler(new ThreadPoolExecutor.CallerRunsPolicy());
195195
} else {
196196
blockQueue = null;

server/build.sbt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ organization := "com.github.dcshock"
22

33
name := "forklift-server"
44

5-
version := "0.24"
5+
version := "0.25"
66

77
enablePlugins(JavaAppPackaging)
88

@@ -15,7 +15,7 @@ initialize := {
1515
}
1616

1717
libraryDependencies ++= Seq(
18-
"com.github.dcshock" % "forklift" % "0.18",
18+
"com.github.dcshock" % "forklift" % "0.19",
1919
"com.github.dcshock" % "forklift-activemq" % "0.9",
2020
"com.github.dcshock" % "forklift-replay" % "0.8",
2121
"com.github.dcshock" % "forklift-retry" % "0.10",

0 commit comments

Comments
 (0)