fix(vm): add hiding of the NetworkReady condition when its status is Unknown. (#1567)

This PR adjusts the NetworkInterfaceHandler to remove the NetworkReady condition when its status resolves to Unknown, and updates corresponding unit tests to expect the condition to be absent rather than present with an Unknown status.

Signed-off-by: Dmitry Lopatin <[email protected]>

Author: LopatinDmitr

images/virtualization-artifact/pkg/controller/vm/internal/network.go

@@ -65,7 +65,11 @@ func (h *NetworkInterfaceHandler) Handle(ctx context.Context, s state.VirtualMac
 		Generation(vm.GetGeneration())
 
 	defer func() {
-		conditions.SetCondition(cb, &vm.Status.Conditions)
+		if cb.Condition().Status == metav1.ConditionUnknown {
+			conditions.RemoveCondition(vmcondition.TypeNetworkReady, &vm.Status.Conditions)
+		} else {
+			conditions.SetCondition(cb, &vm.Status.Conditions)
+		}
 	}()
 
 	if len(vm.Spec.Networks) > 1 {

images/virtualization-artifact/pkg/controller/vm/internal/network_test.go

@@ -134,16 +134,14 @@ var _ = Describe("NetworkInterfaceHandler", func() {
 				err := fakeClient.Get(ctx, client.ObjectKeyFromObject(vm), newVM)
 				Expect(err).NotTo(HaveOccurred())
 
-				cond, exists := conditions.GetCondition(vmcondition.TypeNetworkReady, newVM.Status.Conditions)
-				Expect(exists).To(BeTrue())
-				Expect(cond.Status).To(Equal(metav1.ConditionUnknown))
-				Expect(cond.Reason).To(Equal(conditions.ReasonUnknown.String()))
+				_, exists := conditions.GetCondition(vmcondition.TypeNetworkReady, newVM.Status.Conditions)
+				Expect(exists).To(BeFalse())
 				Expect(newVM.Status.Networks).NotTo(BeNil())
 			})
 		})
 
 		Describe("NetworkSpec have only 'Main' interface", func() {
-			It("Network status is not exist; Condition should have status 'False'", func() {
+			It("Condition should have status 'Unknown'", func() {
 				networkSpec := []v1alpha2.NetworksSpec{
 					{
 						Type: v1alpha2.NetworksTypeMain,
@@ -157,10 +155,8 @@ var _ = Describe("NetworkInterfaceHandler", func() {
 				err := fakeClient.Get(ctx, client.ObjectKeyFromObject(vm), newVM)
 				Expect(err).NotTo(HaveOccurred())
 
-				cond, exists := conditions.GetCondition(vmcondition.TypeNetworkReady, newVM.Status.Conditions)
-				Expect(exists).To(BeTrue())
-				Expect(cond.Status).To(Equal(metav1.ConditionUnknown))
-				Expect(cond.Reason).To(Equal(conditions.ReasonUnknown.String()))
+				_, exists := conditions.GetCondition(vmcondition.TypeNetworkReady, newVM.Status.Conditions)
+				Expect(exists).To(BeFalse())
 				Expect(newVM.Status.Networks).NotTo(BeNil())
 			})
 		})