From 425a03976f38942b0ac6f0ab782470e6443962e4 Mon Sep 17 00:00:00 2001 From: jholdstock Date: Thu, 5 Feb 2026 08:39:52 +0000 Subject: [PATCH 1/3] blockchain: Remove unnecessary nil check from test --- internal/blockchain/utxocache_test.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/internal/blockchain/utxocache_test.go b/internal/blockchain/utxocache_test.go index 3e7aecdd18..0b24ba4ae0 100644 --- a/internal/blockchain/utxocache_test.go +++ b/internal/blockchain/utxocache_test.go @@ -1,4 +1,4 @@ -// Copyright (c) 2022 The Decred developers +// Copyright (c) 2022-2026 The Decred developers // Use of this source code is governed by an ISC // license that can be found in the LICENSE file. @@ -1255,10 +1255,7 @@ func TestMaybeFlush(t *testing.T) { backendEntries[outpoint] = entry } } - if err != nil { - t.Fatalf("%q: unexpected error fetching entries from test "+ - "backend: %v", test.name, err) - } + if !reflect.DeepEqual(backendEntries, test.wantBackendEntries) { t.Fatalf("%q: mismatched backend entries:\nwant: %+v\n got: %+v\n", test.name, test.wantBackendEntries, backendEntries) From 634f9e1df7011ea5cbf783b96887fab8cd11e298 Mon Sep 17 00:00:00 2001 From: jholdstock Date: Thu, 5 Feb 2026 08:42:02 +0000 Subject: [PATCH 2/3] wire: Remove unnecessary nil check from test --- wire/msgcfilter_test.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/wire/msgcfilter_test.go b/wire/msgcfilter_test.go index 7343531d5a..ac482eba5f 100644 --- a/wire/msgcfilter_test.go +++ b/wire/msgcfilter_test.go @@ -1,4 +1,4 @@ -// Copyright (c) 2019-2020 The Decred developers +// Copyright (c) 2019-2026 The Decred developers // Use of this source code is governed by an ISC // license that can be found in the LICENSE file. @@ -65,9 +65,6 @@ func TestCFilter(t *testing.T) { // Ensure encoding with max CF data per message returns no error. data = make([]byte, MaxCFilterDataSize) msg = NewMsgCFilter(blockHash, GCSFilterExtended, data) - if err != nil { - t.Fatalf("NewMsgCFilter: %v", err) - } var buf bytes.Buffer err = msg.BtcEncode(&buf, pver) if err != nil { From a3a90709b605bded3e37b672b336fb3cf32077eb Mon Sep 17 00:00:00 2001 From: jholdstock Date: Thu, 5 Feb 2026 08:40:54 +0000 Subject: [PATCH 3/3] certgen: Check correct var in test. --- certgen/certgen_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/certgen/certgen_test.go b/certgen/certgen_test.go index 1e22e76d1a..3865e2ce38 100644 --- a/certgen/certgen_test.go +++ b/certgen/certgen_test.go @@ -1,5 +1,5 @@ // Copyright (c) 2013-2015 The btcsuite developers -// Copyright (c) 2015 The Decred developers +// Copyright (c) 2015-2026 The Decred developers // Use of this source code is governed by an ISC // license that can be found in the LICENSE file. @@ -38,7 +38,7 @@ func TestNewTLSCertPair(t *testing.T) { // Ensure the PEM-encoded key that is returned can be decoded. pemKey, _ := pem.Decode(key) - if pemCert == nil { + if pemKey == nil { t.Fatalf("pem.Decode was unable to decode the key") }