server: Cleanup external address discovery.#3640
Open
davecgh wants to merge 1 commit intodecred:masterfrom
Open
server: Cleanup external address discovery.#3640davecgh wants to merge 1 commit intodecred:masterfrom
davecgh wants to merge 1 commit intodecred:masterfrom
Conversation
davecgh
force-pushed
the
server_external_addr_discovery
branch
from
221a417 to
1bb946e
Compare
davecgh
force-pushed
the
server_external_addr_discovery
branch
from
1bb946e to
f7d3721
Compare
davecgh
force-pushed
the
server_external_addr_discovery
branch
from
f7d3721 to
10a916d
Compare
This current code that handles the external server address discovery is rather difficult to follow because it is poorly named and interspersed with other code that is not related. This refactors the code to make it better separated and easier to follow. It also switches the main data structure that limits the number of addresses to use an LRU instead. While refactoring this, I noticed there is room for improvement in terms of the logic as well. However, in order to keep the changes easier to review for correctness, this does not contain any notable overall logic changes and limits the changes to refactors and cleanup.
davecgh
force-pushed
the
server_external_addr_discovery
branch
from
10a916d to
6db68f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires #3638.This current code that handles the external server address discovery is rather difficult to follow because it is poorly named and interspersed with other code that is not related.
This refactors the code to make it better separated and easier to follow. It also switches the main data structure that limits the number of addresses to use an LRU instead.
While refactoring this, I noticed there is room for improvement in terms of the logic as well. However, in order to keep the changes easier to review for correctness, this does not contain any notable overall logic changes and limits the changes to refactors and cleanup.