Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Error when executing "dpgen -h" #1719

Closed
roberto160275 opened this issue Feb 20, 2025 · 7 comments · Fixed by #1714
Closed

[BUG] Error when executing "dpgen -h" #1719

roberto160275 opened this issue Feb 20, 2025 · 7 comments · Fixed by #1714
Assignees
Labels
bug Something isn't working

Comments

@roberto160275
Copy link

Bug summary

I installed dpgen 0.13.0 using conda. Installation went smoothly. I tested the installation by issuing "dpgen -h" on the command line and got this output:

Traceback (most recent call last):
File "/home/llovera/miniconda3/envs/deepmd-3.0.1/bin/dpgen", line 5, in
from dpgen.main import main
File "/home/llovera/miniconda3/envs/deepmd-3.0.1/lib/python3.12/site-packages/dpgen/main.py", line 9, in
from dpgen.auto_test.run import gen_test
File "/home/llovera/miniconda3/envs/deepmd-3.0.1/lib/python3.12/site-packages/dpgen/auto_test/run.py", line 8, in
from dpgen.auto_test.common_equi import make_equi, post_equi, run_equi
File "/home/llovera/miniconda3/envs/deepmd-3.0.1/lib/python3.12/site-packages/dpgen/auto_test/common_equi.py", line 8, in
import dpgen.auto_test.lib.abacus as abacus
File "/home/llovera/miniconda3/envs/deepmd-3.0.1/lib/python3.12/site-packages/dpgen/auto_test/lib/abacus.py", line 7, in
from dpdata.abacus.scf import make_unlabeled_stru
ImportError: cannot import name 'make_unlabeled_stru' from 'dpdata.abacus.scf' (/home/llovera/miniconda3/envs/deepmd-3.0.1/lib/python3.12/site-packages/dpdata/abacus/scf.py)

DP-GEN Version

0.13.0

Platform, Python Version, Remote Platform, etc

Python version is 3.12.9

Input Files, Running Commands, Error Log, etc.

Error log in "Bug Summary" section.

Steps to Reproduce

Issue "dpgen -h" after installation using "conda install dpgen -c conda-forge".

Further Information, Files, and Links

No response

@roberto160275 roberto160275 added the bug Something isn't working label Feb 20, 2025
@pxlxingliang
Copy link
Contributor

This bug will be fixed by: #1714

@njzjz
Copy link
Member

njzjz commented Feb 21, 2025

This bug will be fixed by: #1714

#1714 makes new dpgen compatible with new dpdata. Could you consider making dpdata compatible with the old dpgen?

@pxlxingliang
Copy link
Contributor

This bug will be fixed by: #1714

#1714 makes new dpgen compatible with new dpdata. Could you consider making dpdata compatible with the old dpgen?

The function and interface design of the old dpdata abacus part is rather confusing, I think it is better not to use the previous interface

@njzjz
Copy link
Member

njzjz commented Feb 21, 2025

This bug will be fixed by: #1714

#1714 makes new dpgen compatible with new dpdata. Could you consider making dpdata compatible with the old dpgen?

The function and interface design of the old dpdata abacus part is rather confusing, I think it is better not to use the previous interface

Ok. This looks acceptable as I don't see any disadvantage to use the new version.

@njzjz njzjz linked a pull request Feb 21, 2025 that will close this issue
@njzjz njzjz closed this as completed Feb 21, 2025
@roberto160275
Copy link
Author

Thank you all for replying. I'm sorry but, does this mean this issue has been fixed? Do I need to upgrade to a new version to fix this issue on my machine?

Greetings.

@njzjz
Copy link
Member

njzjz commented Feb 22, 2025

Hi, I've released the new version that should fix this issue.

@roberto160275
Copy link
Author

Hi, I've released the new version that should fix this issue.

Thank you so much. It works well now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants